Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't add cite in Quote block #6404

Closed
samikeijonen opened this issue Apr 25, 2018 · 4 comments
Closed

Can't add cite in Quote block #6404

samikeijonen opened this issue Apr 25, 2018 · 4 comments
Labels
[Type] Bug An existing feature does not function as intended

Comments

@samikeijonen
Copy link
Contributor

samikeijonen commented Apr 25, 2018

Issue Overview

I guess blockquote is now using nested blocks. But I can't add cite in Quote block now.

Steps to Reproduce (for bugs)

  1. Add Quote block
  2. Try to add cite.
  3. Where is it?
  4. Can't add it:)
  5. Everything looks a mess.

Screenshots / Video

quote

cc: @jasmussen

@jasmussen jasmussen added the [Type] Bug An existing feature does not function as intended label Apr 25, 2018
@jasmussen
Copy link
Contributor

Thanks for reporting this. It seems to have been a regression from #6054

@jasmussen
Copy link
Contributor

It actually is possible to add a citation, you have to select the quote parent block in order to do so:

selecting parent block

As more blocks get converted to using child blocks, we should find a better way than the hover breadcrumbs to select child blocks.

Also related, #6459

@samikeijonen
Copy link
Contributor Author

Ahaa, that's hidden well:) Write citation placeholder could just be there all the time.

@mcsf
Copy link
Contributor

mcsf commented Apr 30, 2018

Closing per reverting of #6054

@mcsf mcsf closed this as completed Apr 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Bug An existing feature does not function as intended
Projects
None yet
Development

No branches or pull requests

3 participants