Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Embed: implement empty state #551

Closed
mtias opened this issue Apr 28, 2017 · 0 comments
Closed

Embed: implement empty state #551

mtias opened this issue Apr 28, 2017 · 0 comments
Assignees
@BE-Webdesign
Labels
[Feature] Blocks Overall functionality of blocks [Type] Task Issues or PRs that have been broken down into an individual action to take
Milestone
May Week 1

Comments

@mtias
Copy link
Member

mtias commented Apr 28, 2017

image
@mtias mtias added [Feature] Blocks Overall functionality of blocks [Type] Task Issues or PRs that have been broken down into an individual action to take labels Apr 28, 2017
@mtias mtias added this to the May Week 1 milestone May 1, 2017
@BE-Webdesign BE-Webdesign self-assigned this May 2, 2017
BE-Webdesign added a commit that referenced this issue May 2, 2017
@BE-Webdesign
Add embed block placeholder.
372ad0c 
Closes #551.

This PR adds a placeholder for the embed block.  Currently it does not
function and merely serves as a step forward on the UI.

**Testing Instruction:**

Open the inserter menu and add an embed block to the editor.  The embed
block should feature an input to submit the URL.  This functionality
does not yet work but serves as a placeholder.

**Note:**

Someone needs to do the translation build, as Windows breaks it.
@BE-Webdesign BE-Webdesign mentioned this issue May 2, 2017
Merged
BE-Webdesign added a commit that referenced this issue May 4, 2017
@BE-Webdesign
Add embed block placeholder.
6c49179 
Closes #551.

This PR adds a placeholder for the embed block.  Currently it does not
function and merely serves as a step forward on the UI.

**Testing Instruction:**

Open the inserter menu and add an embed block to the editor.  The embed
block should feature an input to submit the URL.  This functionality
does not yet work but serves as a placeholder.

**Note:**

Someone needs to do the translation build, as Windows breaks it.
@nylen nylen closed this as completed in #603 May 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BE-Webdesign BE-Webdesign

Labels
[Feature] Blocks Overall functionality of blocks [Type] Task Issues or PRs that have been broken down into an individual action to take
Projects
None yet
Milestone
May Week 1
Development

No branches or pull requests
2 participants
@mtias @BE-Webdesign