Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove link action of Link UI for draft pages created from Nav block does not correctly remove link #50180

Closed
getdave opened this issue Apr 28, 2023 · 0 comments · Fixed by #52415
Closed

Remove link action of Link UI for draft pages created from Nav block does not correctly remove link #50180

getdave opened this issue Apr 28, 2023 · 0 comments · Fixed by #52415
Assignees
@vcanales @jorgefilipecosta
Labels
[Block] Navigation Affects the Navigation Block [Feature] Link Editing Link components (LinkControl, URLInput) and integrations (RichText link formatting) [Type] Bug An existing feature does not function as intended

Comments

@getdave
Copy link
Contributor

getdave commented Apr 28, 2023 •
edited by richtabor
Loading

If you use the Link UI to create a draft page within the Navigation block then if you click "Remove link" on the resulting link it will not correctly remove it.

We need to fix it so that it behaves in the same way as other links.

Screenshot 2023-04-28 at 16 10 53

CleanShot.2023-04-28.at.14.34.03.mp4
@getdave getdave added [Type] Bug An existing feature does not function as intended [Block] Navigation Affects the Navigation Block [Feature] Link Editing Link components (LinkControl, URLInput) and integrations (RichText link formatting) labels Apr 28, 2023
@richtabor richtabor added this to Polish Apr 28, 2023
This was referenced Apr 28, 2023
Closed
Closed
@priethor priethor moved this to Needs development in Polish Apr 30, 2023
@jorgefilipecosta jorgefilipecosta self-assigned this Jul 7, 2023
@jorgefilipecosta jorgefilipecosta mentioned this issue Jul 7, 2023
Merged
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Jul 7, 2023
@jorgefilipecosta jorgefilipecosta moved this from Needs development to Needs review in Polish Jul 7, 2023
vcanales pushed a commit that referenced this issue Jul 11, 2023
Fix: enable link editing on draft link removal
c96d173 
Fixes: #50180
@vcanales vcanales mentioned this issue Jul 11, 2023
Closed
@priethor priethor removed the [Status] In Progress Tracking issues with work in progress label Jul 14, 2023
@priethor priethor moved this from Needs review to Done in Polish Jul 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vcanales vcanales

@jorgefilipecosta jorgefilipecosta

Labels
[Block] Navigation Affects the Navigation Block [Feature] Link Editing Link components (LinkControl, URLInput) and integrations (RichText link formatting) [Type] Bug An existing feature does not function as intended
Projects
Polish
Status: Done
Milestone
No milestone
4 participants
@getdave @vcanales @jorgefilipecosta @priethor