Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Widget Editor: Can't drag a block to an empty widget area #25911

Closed
mapk opened this issue Oct 7, 2020 · 2 comments · Fixed by #26051
Closed

Widget Editor: Can't drag a block to an empty widget area #25911

mapk opened this issue Oct 7, 2020 · 2 comments · Fixed by #26051
Assignees
@talldan
Labels
[Feature] Widgets Screen The block-based screen that replaced widgets.php. Needs Dev Ready for, and needs developer efforts [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended

Comments

@mapk
Copy link
Contributor

mapk commented Oct 7, 2020

Problem

I can't drag and drop a block/widget to the bottom of another widget area. Nor can I drop a block/widget into an empty area.

Dragging to bottom

drag-to-bottom

Dragging to an empty area

drag-to-empty
@mapk mapk added [Type] Bug An existing feature does not function as intended Needs Dev Ready for, and needs developer efforts [Feature] Widgets Screen The block-based screen that replaced widgets.php. labels Oct 7, 2020
@mapk mapk mentioned this issue Oct 7, 2020
Closed
@talldan
Copy link
Contributor

talldan commented Oct 13, 2020

I can't reproduce the issue with dragging to the bottom, but indeed it doesn't seem to be possible to drop in an empty area.

@talldan talldan changed the title Widget Editor: Can't drag a block to bottom of another area Widget Editor: Can't drag a block to an empty widget area Oct 13, 2020
@kevin940726 kevin940726 self-assigned this Oct 13, 2020
@talldan
Copy link
Contributor

talldan commented Oct 13, 2020

The problem for empty areas is that the drop zone area is effectively 0px high because the appender isn't shown, so there's no target for dragging blocks. This could be fairly simple fix for widget areas of adding a min height to the block list layout component.

There may also be the same issue in other editors/blocks.

@kevin940726 kevin940726 assigned talldan and unassigned kevin940726 Oct 13, 2020
This was referenced Oct 13, 2020
Closed
Merged
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Oct 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@talldan talldan

Labels
[Feature] Widgets Screen The block-based screen that replaced widgets.php. Needs Dev Ready for, and needs developer efforts [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix drag and drop in empty widget area WordPress/gutenberg
3 participants
@mapk @talldan @kevin940726