Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Widget Editor: Unable to move blocks between widget areas. #25766

Closed
paaljoachim opened this issue Oct 1, 2020 · 21 comments
Closed

Widget Editor: Unable to move blocks between widget areas. #25766

paaljoachim opened this issue Oct 1, 2020 · 21 comments
Labels
[Feature] Widgets Screen The block-based screen that replaced widgets.php. [Type] Bug An existing feature does not function as intended

Comments

@paaljoachim
Copy link
Contributor

I am testing out how to move a widget from one widget area to another.

Test 1
using the up and down move arrows.
Moving-widget-to-another-widget-area

It goes to the bottom of the widget area. I am not able to use the down arrow to move it to the next widget area.

Test 2
Using the 3 dot drop down menu. Move to.
Widget-Screen-Move-To

That does not at all work. I see a blue line but I do not know how it is associated with the Move to action.

I am not able to use the Move to action.

@paaljoachim paaljoachim added [Type] Bug An existing feature does not function as intended [Feature] Widgets Screen The block-based screen that replaced widgets.php. labels Oct 1, 2020
@paaljoachim paaljoachim changed the title Widget screen: Not able to move a widget/block from one widget area to another. Widget screen: Not able to use the Move To action to move widget/block from one widget area to another. Oct 1, 2020
@noisysocks noisysocks added the Needs Design Needs design efforts. label Oct 2, 2020
@noisysocks
Copy link
Member

I agree we need a way to move a block to a different area without using drag and drop.

@noisysocks
Copy link
Member

Move To is working, albeit it's confusing. If you select Move To you can then use Tab and Shift+Tab to move the blue cursor around.

@paaljoachim
Copy link
Contributor Author

paaljoachim commented Oct 6, 2020

I do believe this might be the best option.
Adding a submenu to the Move To option. Something similar to this, just prettier.

Widget-Screen-Move-Widget

@mapk

@mapk
Copy link
Contributor

mapk commented Oct 6, 2020

So one way to do this is just cutting and pasting the block into another area like so:

cut-paste

I'm okay using "Move to" but it should NOT change the behavior from the post editor. The behaviors should remain the same with an added "Move to" selected widget area.

@mapk
Copy link
Contributor

mapk commented Oct 6, 2020

I'm finding it very difficult to use the keyboard to jump between widget areas. If this was refined, the "Move to" could work much better. I'll create an issue around using the keyboard to jump between areas.

@paaljoachim
Copy link
Contributor Author

paaljoachim commented Oct 6, 2020

So there is a Move to option in the post editor as well. Never really used it. It is a bit confusing and cumbersome to use.

Adding a cut & paste and drag of widgets between widget areas will help.
#25243

@mapk
Copy link
Contributor

mapk commented Oct 7, 2020

Related: #25911

I think we have a good way forward by implementing these as you mention, @paaljoachim.

Adding a cut & paste and drag of widgets between widget areas will help.

Let's get this to dev. :)

@mapk mapk added Needs Dev Ready for, and needs developer efforts and removed Needs Design Needs design efforts. labels Oct 7, 2020
@talldan
Copy link
Contributor

talldan commented Oct 19, 2020

What's the thing that Needs Dev here? Cut, copy, paste should work, and drag and drop is tracked by other (now closed) issues.

@talldan talldan added the [Status] Needs More Info Follow-up required in order to be actionable. label Oct 19, 2020
@mapk
Copy link
Contributor

mapk commented Oct 19, 2020

@talldan, the Move To option just doesn't seem to work when trying to move one block/widget from one area to another. Here's a video of me trying the Move To without any success. I tried with a both a mouse and using the keyboard. I couldn't get it to happen.

moveto

Problem

When I'm inside a widget area, I can't easily switch to another widget area using the keyboard. I did happen to see a grey line in between widget areas appear which was really weird.

Screen Shot 2020-10-19 at 1 50 16 PM

And in other cases,

@mapk
Copy link
Contributor

mapk commented Oct 19, 2020

Okay, tried this again, and there seems to be a really confusing requirement that a Move To needs to have two blocks in another area to actually move the new block between? Here's another video of me trying again. It wasn't consistent after clicking "Move To" what got highlighted. It would NOT move the block until I selected a block in the other area.

again

Solution

I should be able to select a widget area and drop the block inside it, at the bottom, without having to click into the widget area.

@garretthyder
Copy link
Contributor

For myself this action is extremely confusing. The Move To button feels to have no action or tell as to what your next step is.
I did like @paaljoachim idea of giving the moveto a direct action menu which is the current list of sidebars and widgets/blocks.

@talldan
Copy link
Contributor

talldan commented Oct 20, 2020

It is a bit difficult to understand, it was mostly implemented for screenreader users IIRC and there are some audible instructions.

Anyway, my understanding is it primarily works using arrow keys, up/down for moving up and down, left/right for un-nesting/nesting. Right key works when the insertion line is above the block you want to nest into.

There was a design somewhere showing some visible instructions for using move to mode. @paaljoachim do you remember seeing that? I couldn't find it 😄

@paaljoachim
Copy link
Contributor Author

paaljoachim commented Oct 20, 2020

Hey Dan @talldan

I am not sure if I have seen any design of the Move to mode. As I had not noticed that the mode even existed earlier as I went and added the action menu mockup further above which was mentioned by @garretthyder.

@talldan
Copy link
Contributor

talldan commented Oct 20, 2020

Ah, I was thinking of this issue - #25126

@talldan talldan removed the [Status] Needs More Info Follow-up required in order to be actionable. label Dec 16, 2020
@talldan
Copy link
Contributor

talldan commented Dec 16, 2020

So just to follow up, it seems like the action here would be to make the arrow keys used for Move To clearer. Does that sound correct @mapk @paaljoachim?

@noisysocks noisysocks added Needs Design Feedback Needs general design feedback. and removed Needs Dev Ready for, and needs developer efforts labels Jan 5, 2021
@paaljoachim
Copy link
Contributor Author

paaljoachim commented Jan 6, 2021

An overview
I just went through this issue. A few things that have been brought up are...

  1. Dragging & dropping a widget from one widget area to another works a lot better now than earlier versions.
    Check.

  2. Being able to move a widget/block between widget areas using the arrow icons is I believe on stand still for now. (One can move a block inside a widget area using arrow icons.)
    This is a broader issue related to the post editor and the widget screen.

  3. Keyboard shortcuts. Cut & Paste of widget/block. Does not work on my Mac.

  4. "Move to" inside the 3 dotted menu. Is still very confusing feature.
    @talldan I do believe the actionable item here would be to figure out an improved method for the "Move to" feature for the post editor and the widget screen. Looking at Keyboard in select mode: Show available moves #25126 to get some inspiration. The question comes up. What should happen when one clicks "Move To" ?
    Should it go into select mode with hit areas beside the label of each block/widget, so one can click the hit area and have the block/widget moved to the new location? Something similar to the below perhaps... I am sharing a possible concept. Where one activates the "Move to" feature and the layout changes to reflect an action is about to take place.

-Select "Move To"
-Goes into Select mode and shows an icon/hit area etc with the words move here.

Widget-screen-Move-To

What is missing is an obvious border etc around the block/widget that will be moved.

@shaunandrews
Copy link
Contributor

I think this issue maybe got a little distracted.

The issue remains that the block movers and "Move to..." functionality do not allow for moving a block between widget areas.

For block movers, I expect that clicking the down arrow for a block at the end of an area would move the block to the next area, if one exists. If one doesn't exist, then the down arrow should be disabled.

With the "Move to..." functionality, hitting the down arrow on my keyboard should display the insertion guide in the next area, if one exists. If one doesn't exist, then an audible message should indicate that you've reached the end of the last area.

@shaunandrews shaunandrews removed the Needs Design Feedback Needs general design feedback. label Jan 13, 2021
@shaunandrews shaunandrews changed the title Widget screen: Not able to use the Move To action to move widget/block from one widget area to another. Widget Editor: Unable to move blocks between widget areas. Jan 13, 2021
@talldan
Copy link
Contributor

talldan commented Jan 14, 2021

For block movers, I expect that clicking the down arrow for a block at the end of an area would move the block to the next area, if one exists. If one doesn't exist, then the down arrow should be disabled.

With the "Move to..." functionality, hitting the down arrow on my keyboard should display the insertion guide in the next area, if one exists. If one doesn't exist, then an audible message should indicate that you've reached the end of the last area.

This is probably another area where it might be confusing that widget areas are blocks. It's not possible to move blocks between other container blocks in that way, for example two adjacent groups. But @paaljoachim did make an issue proposing that here - #24328.

The other option is to implement widget areas differently (make them not blocks, or make them 'passthrough' blocks) and have it work the way described.

@shaunandrews
Copy link
Contributor

It's not possible to move blocks between other container blocks

This feels like the root problem to solve.

@hedgefield
Copy link

Yes, and to me it makes sense to do that for the post editor also, as @paaljoachim suggests in #24328. I think implementing that suggestion will solve this issue as well, right?

@talldan
Copy link
Contributor

talldan commented Apr 16, 2021

To summarise this issue, I think there are two things that have been noted as improvements:

For the widget screens, #30896 and #30826 solve the issue of moving blocks between widget areas, so I think we can close this issue.

@talldan talldan closed this as completed Apr 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Widgets Screen The block-based screen that replaced widgets.php. [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

No branches or pull requests

7 participants