Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Site Editor: Improve post content block and template visibility #25089

Closed
jeyip opened this issue Sep 5, 2020 · 2 comments
Closed

Site Editor: Improve post content block and template visibility #25089

jeyip opened this issue Sep 5, 2020 · 2 comments

Comments

@jeyip
Copy link
Contributor

jeyip commented Sep 5, 2020

Note:
When we say "template" in template visibility, we mean the part of the site editor template that doesn't belong to another entity. In other words, it's the area between our template parts and post content.

Is your feature request related to a problem? Please describe.
Related to this issue and this comment.

It's difficult to discern where the post content block and template begins and ends in the site editor. It also seems unintuitive to navigate seamlessly between template parts, the template area, and post content in the site editor.

It's important to call out that the editing experience may improve when Shaun's changes to the topbar are implemented (#25085) alongside a persistent block navigator (#22113). As a result, this issue is acting as more of a placeholder to ensure that, when template part visiblity is improved, the template area and post content block editing experience are addressed as well.

@jeyip jeyip changed the title Site Editor: Improve template area and the post content block visibility Site Editor: Improve template area and post content block visibility Sep 9, 2020
@Addison-Stavlo
Copy link
Contributor

Addison-Stavlo commented Sep 9, 2020

Post Content I feel the needs of this block are very similar to that of the Template Part. So whatever fits the needs of the template part should ideally fit the needs of the post content (whether persistent block navigator and breadcrumb names are sufficient on their own, or we need to add other indicators like borders, labels, scrims, spotlights, etc., my feeling is that these two blocks will require the same sort of indications).

Template areas may be a bit different though, as the two entity blocks mentioned above are children of the Template. So if there is a need for visual indications (beyond block navigator and breadcrumb names), those visual indicators will definitely be a bit different. Perhaps, if we do something like apply a very light border around template part and post content when working within them then a solution for the Template area could be to triggers those light borders to appear for all the Template Parts/Post Contents on the page when working within the template area. This kind of thing might make it more clear where you are working on the page.

That said:

It's important to call out that the editing experience may improve when Shaun's changes to the topbar are implemented (#25085) alongside a persistent block navigator (#22113). As a result, this issue is acting as more of a placeholder to ensure that, when template part visiblity is improved, the template area and post content block editing experience are addressed as well.

It does sound like a good idea to assess this after we see where our weak points are after the above is implemented.

@jeyip jeyip changed the title Site Editor: Improve template area and post content block visibility Site Editor: Improve post content block and template visibility Sep 9, 2020
@annezazu
Copy link
Contributor

I am closing this out after an immense amount of work has gone into clarifying the relationship between the content and the template: #51366 #51364 #50857 There is no clarity both in terms of interfaces nudges when you click on a template while editing post content and to switch between the two. If I missed something here though, let me know and I'm happy to reopen!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants