Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Site Editor: Improving UX when modifying site editor blocks #24881

Closed
jeyip opened this issue Aug 28, 2020 · 12 comments
Closed

Site Editor: Improving UX when modifying site editor blocks #24881

jeyip opened this issue Aug 28, 2020 · 12 comments
Labels
[Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") Needs Design Needs design efforts.

Comments

@jeyip
Copy link
Contributor

jeyip commented Aug 28, 2020

Problem

Blocks like site icon, site title, and site description blocks:

  1. Pull information from different data sources than normal blocks (like paragraph, heading, etc.)
  2. Will, when updated, modify all instances of the block, including where it exists outside of this view in the site editor. This in contrast to, for example, a paragraph block, which does not modify other paragraph blocks in different views.

Screen Shot 2020-08-27 at 9 55 42 PM

The existing site editor UI doesn't indicate that these blocks behave differently than traditional blocks. It seems like we could find better ways to set expectations with the user and let them know that modifying certain elements of their page causes broader changes on their website.

@jeyip jeyip changed the title Site Editor: Improving the UX when modifying site editor blocks Site Editor: Improving UX when modifying site editor blocks Aug 28, 2020
@jeyip jeyip added Needs Design Feedback Needs general design feedback. Needs Design Needs design efforts. and removed Needs Design Feedback Needs general design feedback. labels Aug 28, 2020
@jeyip
Copy link
Contributor Author

jeyip commented Aug 28, 2020

@noahtallen, @Addison-Stavlo, and I are planning to tackle this as part of our efforts to improve the editing experience for the site editor. @MichaelArestad @shaunandrews @dubielzyk we're looking to kick off discussions here. Do y'all have any thoughts or opinions on this?

@mtias
Copy link
Member

mtias commented Aug 28, 2020

Not sure I agree they should be different in the editing view. The "update design" flow is meant to highlight those things. To the user, the distinction between global and local is going to be elusive. Local blocks like a paragraph can also suddenly become global if they are placed within a template area or a reusable block.

@mtias mtias added Needs Design Feedback Needs general design feedback. and removed Needs Design Needs design efforts. labels Aug 28, 2020
@Addison-Stavlo
Copy link
Contributor

Local blocks like a paragraph can also suddenly become global if they are placed within a template area or a reusable block.

There is a bit of a distinction here though, its not the same level of being global. Updating a paragraph in one of these areas may change that paragraph on other pages that use that same template or reusable block, but will not bleed over to any other templates or reusable blocks. If a Site Title block is in one of these areas it will still change it for all templates, reusable blocks, or anywhere else it is ever used.

@MichaelArestad MichaelArestad added Needs Design Needs design efforts. and removed Needs Design Feedback Needs general design feedback. labels Aug 28, 2020
@shaunandrews
Copy link
Contributor

It seems like we could find better ways to set expectations with the user and let them know that modifying certain elements of their page causes broader changes on their website.

As Matias mentions above, the intention of the Update Design flow is to help people understand the affects of their changes.

Adding some specific UI to these sort of "global" or "site meta" blocks is more likely to confuse than help.

@vindl
Copy link
Member

vindl commented Aug 28, 2020

Not sure I agree they should be different in the editing view. The "update design" flow is meant to highlight those things.

Updates to site blocks are not shown in "update design" flow now. If we add them the list might become too crowded. Also currently it's not easy to differentiate Site Title and Tagline from Heading and Paragraph blocks at a glance. The only cue is in block breadcrumb which is easy to miss.

@Addison-Stavlo
Copy link
Contributor

Updates to site blocks are not shown in "update design" flow now.

There are some cases where they are (although not as intuitive as they could be). For example changing the site title shows up there:
Screen Shot 2020-08-28 at 1 44 08 PM

But when we first added this in it was seen as too overwhelming and cumbersome to have the entire list of changed entities visible by default. Therefore we updated this flow to hide this info by default (following @MichaelArestad suggestion IIRC) and only show it if the user wants to take that extra step to 'review changes'. This means the insight provided here may be easily missed and skipped over by users who just go ahead and hit 'save':

Screen Shot 2020-08-28 at 1 46 52 PM

@vindl
Copy link
Member

vindl commented Aug 28, 2020

There are some cases where they are (although not as intuitive as they could be). For example changing the site title shows up there:

I retested the flow before the comment to make sure and didn't notice it at the time, but now I see it. 🙃

@shaunandrews
Copy link
Contributor

We could surface site-related blocks (or some set of "important" changes) in the Update Design flow.

@Addison-Stavlo
Copy link
Contributor

We could surface site-related blocks (or some set of "important" changes) in the Update Design flow.

Yeah, that is a possibility!

Summarizing some slack convo with @mtias and @MichaelArestad for visibility:

We may be a bit early in the process to tell how much of a problem this really is or isn't, and there are definitely some other areas that might be more important to focus on for the time being. Its definitely good to think about this, but probably best to revisit after first focusing on making the editing experience clear and easy to navigate regarding the larger chunks in the template ( the template area, the post content area, the template part, etc.)

@noahtallen
Copy link
Member

surface site-related blocks... in the Update Design flow.

I think this could solve the (foreseen) problem with some tweaks to the save flow:

  • Perhaps not hiding them behind the button by default (otherwise the beginners who would most need the information won't find it)
  • Maybe with some updated designs to help visualize exactly where these changes are being applied. I think just saying "site" doesn't totally communicate it for me. Maybe we need some info tooltips you can click on to learn about it more

@mtias
Copy link
Member

mtias commented Aug 29, 2020

And just for the record, showing things like site title in the saving flow was the main point of showing the entities there, it wasn't just for templates and parts. :)

@annezazu annezazu added [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") and removed [Feature] Full Site Editing labels Jul 24, 2023
@jordesign
Copy link
Contributor

Looping back to this older issue. There have been significant updates to the entity saving flow since the issue was opened.

Screenshot 2023-08-24 at 12 57 21 pm

As such I'll close this issue. If there are further items to improve a new issue can be opened referencing the current state.

@jordesign jordesign closed this as not planned Won't fix, can't repro, duplicate, stale Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") Needs Design Needs design efforts.
Projects
None yet
Development

No branches or pull requests

9 participants