Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cover Block: Block styles bleeding into nested image blocks #24458

Closed
alaczek opened this issue Aug 10, 2020 · 3 comments
Closed

Cover Block: Block styles bleeding into nested image blocks #24458

alaczek opened this issue Aug 10, 2020 · 3 comments
Labels
[Block] Cover Affects the Cover Block - used to display content laid over a background image [Status] Stale Gives the original author opportunity to update before closing. Can be reopened as needed. [Type] Bug An existing feature does not function as intended

Comments

@alaczek
Copy link

alaczek commented Aug 10, 2020

Describe the bug
When using cover block with top/bottom wave block style, the wave is also being applied to images nested inside the cover block. Related to #23198

To reproduce
Steps to reproduce the behavior:

  1. Create a post/page and add a cover block. Apply top or bottom wave block style.
  2. Inside the over block insert an image block.
  3. Note how the image is inheriting the top/bottom wave.

Expected behavior
For the wave to not be applied to the nested image.

Screenshots
If applicable, add screenshots to help explain your problem.
image

Editor version (please complete the following information):

  • WordPress version: 5.4.2
  • Gutenberg: default
  • Theme: TwentyTwenty
@ianstewart ianstewart added the [Type] Bug An existing feature does not function as intended label Aug 10, 2020
@skorasaurus skorasaurus added the [Block] Cover Affects the Cover Block - used to display content laid over a background image label May 17, 2021
@kathrynwp
Copy link

kathrynwp commented Aug 2, 2022 •
edited
Loading

@alaczek Hi! I'm not seeing any wave options for the Cover block at the moment. Could you please confirm whether those are coming from WP Core, Gutenberg, or a third-party plugin like CoBlocks? Thanks!

Tested with:

WordPress 6.0.1
Gutenberg 13.7.3 active or inactive
No other plugins active
Twenty Twenty 2.0 or Twenty Twenty-Two 1.2

@kathrynwp kathrynwp added the [Status] Stale Gives the original author opportunity to update before closing. Can be reopened as needed. label Aug 2, 2022
@kathrynwp
Copy link

@alaczek I'm going to go ahead and close this out, but if you are still experiencing the original issue, feel free to add a comment with additional details and I’ll be glad to reopen it.

@kathrynwp kathrynwp closed this as not planned Won't fix, can't repro, duplicate, stale Aug 9, 2022
@alaczek
Copy link
Author

alaczek commented Aug 10, 2022

Yes, the wave style was coming from CoBlocks. The issue can be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Block] Cover Affects the Cover Block - used to display content laid over a background image [Status] Stale Gives the original author opportunity to update before closing. Can be reopened as needed. [Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@ianstewart @skorasaurus @alaczek @kathrynwp