Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cover Block: Prevent styles from applying to the placeholder #23198

Open
WunderBart opened this issue Jun 16, 2020 · 4 comments
Open

Cover Block: Prevent styles from applying to the placeholder #23198

WunderBart opened this issue Jun 16, 2020 · 4 comments
Labels
[Block] Cover Affects the Cover Block - used to display content laid over a background image [Type] Bug An existing feature does not function as intended

Comments

@WunderBart
Copy link
Member

Describe the bug
The Styles setting for the Cover block should not be available initially as they can mask the placeholder interface and cause confusion (especially when one of the "wave" options is selected as a block's default)

To reproduce
Steps to reproduce the behavior:

  1. Add Cover block,
  2. Open the block settings,
  3. Go to the Styles section,
  4. Apply one of the "wave" styles.
  5. See how the placeholder gets masked with that wave shape.

Expected behavior
Styles should not be applicable to the block placeholder. Ideally, they should not appear until a block is set up.

Screenshots

Editor version:
v8.3.0

@WunderBart WunderBart added [Block] Cover Affects the Cover Block - used to display content laid over a background image [Type] Bug An existing feature does not function as intended labels Jun 16, 2020
@richtabor
Copy link
Member

Related to #23122

@richtabor
Copy link
Member

Also, the Bottom Wave and Top Wave styles here are added via a third party block (presumably CoBlocks) - not to say the issue is any less important (as developers continue to extend the editor).

In #23122 I propose that the Styles panels are not available for blocks that utilize placeholder states, so that this issue does not occur.

@jordesign
Copy link
Contributor

This is still somewhat present. The Styles panel is available but doesn't impact the block until you add a background color - at which point the placeholder state is lost

@akasunil
Copy link
Member

based on comment of @getsource in #23122, should we close this issue ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Cover Affects the Cover Block - used to display content laid over a background image [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

No branches or pull requests

4 participants