Block categories: Inconsistent legacy mappings

[sirreal]

Describe the bug

When reviewing changes from #19279, I noticed that the compatibility mappings for legacy block categories appear to have inconsistent mappings in PHP and JavaScript. In PHP formatting is mapped to media, whereas in JavaScript it's mapped to text:

gutenberg/lib/compat.php

Lines 339 to 355 in 84df4bd

	$substitution = array(
	'common' => array(
	'slug' => 'text',
	'title' => __( 'Text', 'gutenberg' ),
	'icon' => null,
	),
	'formatting' => array(
	'slug' => 'media',
	'title' => __( 'Media', 'gutenberg' ),
	'icon' => null,
	),
	'layout' => array(
	'slug' => 'design',
	'title' => __( 'Design', 'gutenberg' ),
	'icon' => null,
	),
	);

gutenberg/packages/blocks/src/api/registration.js

Lines 131 to 135 in 84df4bd

	const LEGACY_CATEGORY_MAPPING = {
	common: 'text',
	formatting: 'text',
	layout: 'design',
	};

I'm not sure how this bug manifests, but I'd expect these mappings to be consistent.

CC: @mtias

[mcsf]

The original PR's description does list Text as the destination for Formatting. I guess we should patch the PHP rules, then, and do it quickly so that no mistakes are carried over in the 5.5 PHP backporting process in #23210.

[gziolo]

There is no mapping in WordPress core. It’s a simple act of replacing categories 😃

[mcsf]

There is no mapping in WordPress core. It’s a simple act of replacing categories 😃

Looking at https://github.com/WordPress/wordpress-develop/blob/24465974cd6333137490b55ab663f3d1f844a95e/src/wp-admin/includes/post.php#L2180-L2210, category Design still needs to be added.

[gziolo]

Design is already there in WordPress core:
https://github.com/WordPress/wordpress-develop/blob/24465974cd6333137490b55ab663f3d1f844a95e/src/wp-admin/includes/post.php#L2191-L2195

I examined code and I think everything looks good. The confusion comes from the fact that the compat layer in PHP only updates the list of default categories and JS does the mapping.

[mcsf]

Design is already there in WordPress core:

Never mind, I don't know how I missed that. 😓