Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Alignfull columns block side margins are not equal. #11869

Closed
kjellr opened this issue Nov 14, 2018 · 0 comments · Fixed by #11904
Closed

Alignfull columns block side margins are not equal. #11869

kjellr opened this issue Nov 14, 2018 · 0 comments · Fixed by #11904
Labels
[Block] Columns Affects the Columns Block [Type] Bug An existing feature does not function as intended

Comments

@kjellr
Copy link
Contributor

kjellr commented Nov 14, 2018 •
edited
Loading

Describe the bug

When you set a columns block to alignfull, the content columns are not centered: there's more space on the right than on the left:

columns-padding

To Reproduce
Steps to reproduce the behavior:

  1. Add a columns block.
  2. Add content to each column.
  3. Note that there's more space on the right than on the left.

Testing
Tested on MacOS 10.14, Safari 12.0.1 and Chrome 70.0.3538.102
Gutenberg 4.3.0
Verified using both Twenty Nineteen, and the Gutenberg starter theme.

cc @jasmussen
@kjellr kjellr added [Type] Bug An existing feature does not function as intended [Block] Columns Affects the Columns Block labels Nov 14, 2018
@kjellr kjellr mentioned this issue Nov 14, 2018
Merged
jasmussen added a commit that referenced this issue Nov 15, 2018
@jasmussen
Columns: Improve margins, column child block, mobile.
883a929 
This PR aims to further improve the columns block, and improving a number of aspects and addressing recent feedback.

- It fixes an issue where fullwide columns had uneven margins, both left, center and right. Fixes #11869.
- It fixes a specificity issue with toolbar and breadcrumb positioning that bled into all child blocks.
- It improves the layout of individual column blocks, and fixes the toolbar positioning. This fixes feedback in #7766 (comment).
- It improves fullwide columns and how they appear on mobile.

Aside from that it simplifies the code a bit, and removes a couple of redundant overrides that were better fixed elsewhere.
@jasmussen jasmussen mentioned this issue Nov 15, 2018
Merged
jasmussen added a commit that referenced this issue Nov 15, 2018
@jasmussen
Columns: Improve margins, column child block, mobile.
53ed4c3 
This PR aims to further improve the columns block, and improving a number of aspects and addressing recent feedback.

- It fixes an issue where fullwide columns had uneven margins, both left, center and right. Fixes #11869.
- It fixes a specificity issue with toolbar and breadcrumb positioning that bled into all child blocks.
- It improves the layout of individual column blocks, and fixes the toolbar positioning. This fixes feedback in #7766 (comment).
- It improves fullwide columns and how they appear on mobile.

Aside from that it simplifies the code a bit, and removes a couple of redundant overrides that were better fixed elsewhere.
youknowriad pushed a commit that referenced this issue Nov 15, 2018
@jasmussen @youknowriad
Columns: Improve margins, column child block, mobile. (#11904)
46ebefa 
* Columns: Improve margins, column child block, mobile.

This PR aims to further improve the columns block, and improving a number of aspects and addressing recent feedback.

- It fixes an issue where fullwide columns had uneven margins, both left, center and right. Fixes #11869.
- It fixes a specificity issue with toolbar and breadcrumb positioning that bled into all child blocks.
- It improves the layout of individual column blocks, and fixes the toolbar positioning. This fixes feedback in #7766 (comment).
- It improves fullwide columns and how they appear on mobile.

Aside from that it simplifies the code a bit, and removes a couple of redundant overrides that were better fixed elsewhere.

* Fix issue with more than 2 columns.

* Prevent columns from growing wider than their set width.

* Use break-word for better word breaks.

* Copy editor style to frontend.
@monzerfoda monzerfoda mentioned this issue Dec 1, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Block] Columns Affects the Columns Block [Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Columns: Improve margins, column child block, mobile. WordPress/gutenberg
1 participant
@kjellr