Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

default link styles conflict with editor button component link #11474

Closed
timelsass opened this issue Nov 5, 2018 · 0 comments · Fixed by #11475
Closed

default link styles conflict with editor button component link #11474

timelsass opened this issue Nov 5, 2018 · 0 comments · Fixed by #11475

Comments

@timelsass
Copy link
Contributor

Describe the bug
Themes provide base styles for components, and one that's almost always present is for links. In testing a theme that has set a:hover, a:focus { text-decoration: underline; } (a common style), I noticed the published panel's "View Page" button inherits the underline from a since no overriding style is supplied.

To Reproduce
Steps to reproduce the behavior:

  1. Create a new page/post.
  2. Publish post (I have the "Always show pre-publish checks." option on).
  3. Hover over the "View Page" link, and you will see the text is underlined.
  4. Hover over the "Copy Link" button, and you will see the text is not underlined.
  5. Repeat steps 3 & 4 with the focus state.

Expected behavior
I expect that the link styled to look like a button would have the same visual presentation in the various states like :hover and :focus.

Screenshots
Hover State:
text-decoration-hover-on-component-button-links

Focus State:
text-decoration-focus-button-component-link

Desktop (please complete the following information):
OS: Ubuntu 18.04.1 LTS
chrome
Version 69.0.3497.92 (Official Build) (64-bit)

Additional context
Replicated in Gutenberg Master Branch
Replicated in Gutenberg Plugin Version 4.1.1 svn

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant