Add a new keyboard shortcut package (#19100)

bin/api-docs/packages.js

@@ -23,6 +23,7 @@ const packages = [
 	'escape-html',
 	'html-entities',
 	'i18n',
+	'keyboard-shortcuts',
 	'keycodes',
 	'plugins',
 	'priority-queue',

docs/designers-developers/developers/data/data-core-block-editor.md

@@ -892,6 +892,14 @@ _Returns_
 
 -   `Object`: Action object.
 
+<a name="duplicateBlocks" href="#duplicateBlocks">#</a> **duplicateBlocks**
+
+Generator that triggers an action used to duplicate a list of blocks.
+
+_Parameters_
+
+-   _clientIds_ `Array<string>`: 
+
 <a name="enterFormattedText" href="#enterFormattedText">#</a> **enterFormattedText**
 
 Returns an action object used in signalling that the caret has entered formatted text.
@@ -916,6 +924,22 @@ _Returns_
 
 -   `Object`: Action object.
 
+<a name="insertAfterBlock" href="#insertAfterBlock">#</a> **insertAfterBlock**
+
+Generator used to insert an empty block before a given block.
+
+_Parameters_
+
+-   _clientId_ `string`: 
+
+<a name="insertBeforeBlock" href="#insertBeforeBlock">#</a> **insertBeforeBlock**
+
+Generator used to insert an empty block after a given block.
+
+_Parameters_
+
+-   _clientId_ `string`: 
+
 <a name="insertBlock" href="#insertBlock">#</a> **insertBlock**
 
 Returns an action object used in signalling that a single block should be

docs/designers-developers/developers/data/data-core-keyboard-shortcuts.md

@@ -0,0 +1,79 @@
+# The Keyboard Shortcuts Data
+
+Namespace: `core/keyboard-shortcuts`.
+
+## Selectors
+
+<!-- START TOKEN(Autogenerated selectors) -->
+
+<a name="getShortcutAliases" href="#getShortcutAliases">#</a> **getShortcutAliases**
+
+Returns the aliases for a given shortcut name.
+
+_Parameters_
+
+-   _state_ `Object`: Global state.
+-   _name_ `string`: Shortcut name.
+
+_Returns_
+
+-   `Array<WPShortcutKeyCombination>`: Key combinations.
+
+<a name="getShortcutDescription" href="#getShortcutDescription">#</a> **getShortcutDescription**
+
+Returns the shortcut description given its name.
+
+_Parameters_
+
+-   _state_ `Object`: Global state.
+-   _name_ `string`: Shortcut name.
+
+_Returns_
+
+-   `?string`: Shortcut description.
+
+<a name="getShortcutKeyCombination" href="#getShortcutKeyCombination">#</a> **getShortcutKeyCombination**
+
+Returns the main key combination for a given shortcut name.
+
+_Parameters_
+
+-   _state_ `Object`: Global state.
+-   _name_ `string`: Shortcut name.
+
+_Returns_
+
+-   `?WPShortcutKeyCombination`: Key combination.
+
+
+<!-- END TOKEN(Autogenerated selectors) -->
+
+## Actions
+
+<!-- START TOKEN(Autogenerated actions) -->
+
+<a name="registerShortcut" href="#registerShortcut">#</a> **registerShortcut**
+
+Returns an action object used to register a new keyboard shortcut.
+
+_Parameters_
+
+-   _config_ `WPShortcutConfig`: Shortcut config.
+
+_Returns_
+
+-   `Object`: action.
+
+<a name="unregisterShortcut" href="#unregisterShortcut">#</a> **unregisterShortcut**
+
+Returns an action object used to unregister a keyboard shortcut.
+
+_Parameters_
+
+-   _name_ `string`: Shortcut name.
+
+_Returns_
+
+-   `Object`: action.
+
+<!-- END TOKEN(Autogenerated actions) -->

docs/manifest-devhub.json

@@ -1355,6 +1355,12 @@
 		"markdown_source": "../packages/jest-puppeteer-axe/README.md",
 		"parent": "packages"
 	},
+	{
+		"title": "@wordpress/keyboard-shortcuts",
+		"slug": "packages-keyboard-shortcuts",
+		"markdown_source": "../packages/keyboard-shortcuts/README.md",
+		"parent": "packages"
+	},
 	{
 		"title": "@wordpress/keycodes",
 		"slug": "packages-keycodes",

docs/tool/packages.js

@@ -8,6 +8,7 @@ const packages = [
 	'core/block-editor',
 	'core/editor',
 	'core/edit-post',
+	'core/keyboard-shortcuts',
 	'core/notices',
 	'core/nux',
 	'core/viewport',

package.json

@@ -49,6 +49,7 @@
 		"@wordpress/html-entities": "file:packages/html-entities",
 		"@wordpress/i18n": "file:packages/i18n",
 		"@wordpress/is-shallow-equal": "file:packages/is-shallow-equal",
+		"@wordpress/keyboard-shortcuts": "file:packages/keyboard-shortcuts",
 		"@wordpress/keycodes": "file:packages/keycodes",
 		"@wordpress/list-reusable-blocks": "file:packages/list-reusable-blocks",
 		"@wordpress/media-utils": "file:packages/media-utils",

packages/block-editor/package.json

@@ -36,6 +36,7 @@
 		"@wordpress/html-entities": "file:../html-entities",
 		"@wordpress/i18n": "file:../i18n",
 		"@wordpress/is-shallow-equal": "file:../is-shallow-equal",
+		"@wordpress/keyboard-shortcuts": "file:../keyboard-shortcuts",
 		"@wordpress/keycodes": "file:../keycodes",
 		"@wordpress/rich-text": "file:../rich-text",
 		"@wordpress/token-list": "file:../token-list",

packages/block-editor/src/components/block-actions/index.js

@@ -8,7 +8,7 @@ import { castArray, first, last, every } from 'lodash';
  */
 import { compose } from '@wordpress/compose';
 import { withSelect, withDispatch } from '@wordpress/data';
-import { cloneBlock, hasBlockSupport, switchToBlockType } from '@wordpress/blocks';
+import { hasBlockSupport, switchToBlockType } from '@wordpress/blocks';
 
 function BlockActions( {
 	canDuplicate,
@@ -72,59 +72,29 @@ export default compose( [
 	withDispatch( ( dispatch, props, { select } ) => {
 		const {
 			clientIds,
-			rootClientId,
 			blocks,
-			isLocked,
-			canDuplicate,
 		} = props;
 
 		const {
-			insertBlocks,
-			multiSelect,
 			removeBlocks,
-			insertDefaultBlock,
 			replaceBlocks,
+			duplicateBlocks,
+			insertAfterBlock,
+			insertBeforeBlock,
 		} = dispatch( 'core/block-editor' );
 
 		return {
 			onDuplicate() {
-				if ( ! canDuplicate ) {
-					return;
-				}
-
-				const { getBlockIndex } = select( 'core/block-editor' );
-				const lastSelectedIndex = getBlockIndex( last( castArray( clientIds ) ), rootClientId );
-				const clonedBlocks = blocks.map( ( block ) => cloneBlock( block ) );
-				insertBlocks(
-					clonedBlocks,
-					lastSelectedIndex + 1,
-					rootClientId
-				);
-				if ( clonedBlocks.length > 1 ) {
-					multiSelect(
-						first( clonedBlocks ).clientId,
-						last( clonedBlocks ).clientId
-					);
-				}
+				return duplicateBlocks( clientIds );
 			},
 			onRemove() {
-				if ( ! isLocked ) {
-					removeBlocks( clientIds );
-				}
+				removeBlocks( clientIds );
 			},
 			onInsertBefore() {
-				if ( ! isLocked ) {
-					const { getBlockIndex } = select( 'core/block-editor' );
-					const firstSelectedIndex = getBlockIndex( first( castArray( clientIds ) ), rootClientId );
-					insertDefaultBlock( {}, rootClientId, firstSelectedIndex );
-				}
+				insertBeforeBlock( first( castArray( clientIds ) ) );
 			},
 			onInsertAfter() {
-				if ( ! isLocked ) {
-					const { getBlockIndex } = select( 'core/block-editor' );
-					const lastSelectedIndex = getBlockIndex( last( castArray( clientIds ) ), rootClientId );
-					insertDefaultBlock( {}, rootClientId, lastSelectedIndex + 1 );
-				}
+				insertAfterBlock( last( castArray( clientIds ) ) );
 			},
 			onGroup() {
 				if ( ! blocks.length ) {