removes id from LinkControl

WordPress · Jul 9, 2020 · f474b7f · f474b7f
1 parent 8cbb49e
commit f474b7f
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 4 deletions.
diff --git a/packages/block-editor/src/components/link-control/index.js b/packages/block-editor/src/components/link-control/index.js
@@ -158,7 +158,6 @@ const makeCancelable = ( promise ) => {
 function LinkControl( {
 	searchInputPlaceholder,
 	value,
-	id,
 	settings,
 	onChange = noop,
 	noDirectEntry = false,
@@ -178,7 +177,7 @@ function LinkControl( {
 	const [ isEditingLink, setIsEditingLink ] = useState(
 		forceIsEditingLink !== undefined
 			? forceIsEditingLink
-			: ! value || ( ! value.url && ! id )
+			: ! value || ( ! value.url && ! value.id )
 	);
 	const [ isResolvingLink, setIsResolvingLink ] = useState( false );
 	const [ errorMessage, setErrorMessage ] = useState( null );
@@ -608,7 +607,7 @@ function LinkControl( {
 							</span>
 						) }
 
-						{ typeof value.url === 'undefined' && (
+						{ typeof value.id !== 'undefined' && (
 							<span className="block-editor-link-control__search-item-header">
 								{ value && value.title && (
 									<span className="block-editor-link-control__search-item-info">

diff --git a/packages/block-library/src/navigation-link/edit.js b/packages/block-library/src/navigation-link/edit.js
@@ -63,6 +63,7 @@ function NavigationLinkEdit( {
 	const { label, opensInNewTab, url, id, nofollow, description } = attributes;
 	const link = {
 		url,
+		id,
 		opensInNewTab,
 		title: label,
 	};
@@ -249,7 +250,6 @@ function NavigationLinkEdit( {
 							<LinkControl
 								className="wp-block-navigation-link__inline-link-input"
 								value={ link }
-								id={ id }
 								showInitialSuggestions={ true }
 								createSuggestion={
 									userCanCreatePages