DataViews: hide actions menu upon selecting a layout (#57418)

WordPress · Dec 28, 2023 · ec2c51d · ec2c51d
1 parent 3f6c738
commit ec2c51d
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/packages/dataviews/src/dropdown-menu-helper.js b/packages/dataviews/src/dropdown-menu-helper.js
@@ -29,7 +29,7 @@ const radioCheck = (
  */
 export const DropdownMenuRadioItemCustom = forwardRef(
 	function DropdownMenuRadioItemCustom(
-		{ checked, name, value, onChange, onClick, ...props },
+		{ checked, name, value, hideOnClick, onChange, onClick, ...props },
 		ref
 	) {
 		const onClickHandler = ( e ) => {
@@ -42,7 +42,7 @@ export const DropdownMenuRadioItemCustom = forwardRef(
 				role="menuitemradio"
 				name={ name }
 				aria-checked={ checked }
-				hideOnClick={ false }
+				hideOnClick={ !! hideOnClick }
 				prefix={
 					checked ? (
 						<Icon icon={ radioCheck } />

diff --git a/packages/dataviews/src/view-actions.js b/packages/dataviews/src/view-actions.js
@@ -54,6 +54,7 @@ function ViewTypeMenu( { view, onChangeView, supportedLayouts } ) {
 						value={ availableView.type }
 						name="view-actions-available-view"
 						checked={ availableView.type === view.type }
+						hideOnClick={ true }
 						onChange={ ( e ) => {
 							onChangeView( {
 								...view,