Escape out of block moving mode.

WordPress · Jun 17, 2020 · d597ac0 · d597ac0
1 parent 49b3ce1
commit d597ac0
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 5 deletions.
diff --git a/packages/block-editor/src/components/block-list/block-selection-button.js b/packages/block-editor/src/components/block-list/block-selection-button.js
@@ -47,11 +47,12 @@ function BlockSelectionButton( {
 			const { name, attributes } = __unstableGetBlockWithoutInnerBlocks(
 				clientId
 			);
-			return { index, name, attributes, isBlockMovingMode };
+			const blockMovingMode = isBlockMovingMode();
+			return { index, name, attributes, blockMovingMode };
 		},
 		[ clientId, rootClientId ]
 	);
-	const { index, name, attributes, isBlockMovingMode } = selected;
+	const { index, name, attributes, blockMovingMode } = selected;
 	const { setNavigationMode, removeBlock } = useDispatch(
 		'core/block-editor'
 	);
@@ -82,7 +83,7 @@ function BlockSelectionButton( {
 	const classNames = classnames(
 		'block-editor-block-list__block-selection-button',
 		{
-			'is-navigate-mode': !! isBlockMovingMode(),
+			'is-block-moving-mode': !! blockMovingMode,
 		}
 	);
 

diff --git a/packages/block-editor/src/components/block-list/style.scss b/packages/block-editor/src/components/block-list/style.scss
@@ -208,9 +208,12 @@
 }
 
 
-.is-navigate-mode.block-editor-block-list__breadcrumb {
+.is-block-moving-mode.block-editor-block-list__breadcrumb {
 	// Should be invisible but not unfocusable.
 	opacity: 0;
+	font-size: 1px;
+	height: 1px;
+	padding: 0;
 }
 
 /**

diff --git a/packages/block-editor/src/components/writing-flow/index.js b/packages/block-editor/src/components/writing-flow/index.js
@@ -451,7 +451,10 @@ export default function WritingFlow( { children } ) {
 					)
 				);
 			}
-
+			if ( isEscape && startingBlockClientId ) {
+				setBlockMovingMode( null );
+				setCanInsertMovingBlock( false );
+			}
 			if ( ( isEnter || isSpace ) && startingBlockClientId ) {
 				const sourceRoot = getBlockRootClientId(
 					startingBlockClientId