Skip to content

Commit

Permalink
Block Editor: Avoid rendering empty Slot for block alignments (#55689)
Browse files Browse the repository at this point in the history
  • Loading branch information
Mamaduka authored Oct 30, 2023
1 parent 62ec891 commit c7c5549
Showing 1 changed file with 11 additions and 8 deletions.
19 changes: 11 additions & 8 deletions packages/block-editor/src/hooks/align.js
Original file line number Diff line number Diff line change
Expand Up @@ -120,17 +120,20 @@ export const withToolbarControls = createHigherOrderComponent(
( BlockEdit ) => ( props ) => {
const blockEdit = <BlockEdit key="edit" { ...props } />;
const { name: blockName } = props;

const blockEditingMode = useBlockEditingMode();
if ( blockEditingMode !== 'default' ) {
return blockEdit;
}

// Compute the block valid alignments by taking into account,
// if the theme supports wide alignments or not and the layout's
// availble alignments. We do that for conditionally rendering
// Slot.
const blockAllowedAlignments = getValidAlignments(
getBlockSupport( blockName, 'align' ),
hasBlockSupport( blockName, 'alignWide', true )
);
if ( blockAllowedAlignments.length === 0 ) {

const validAlignments = useAvailableAlignments(
blockAllowedAlignments
).map( ( { name } ) => name );
const blockEditingMode = useBlockEditingMode();
if ( ! validAlignments.length || blockEditingMode !== 'default' ) {
return blockEdit;
}

Expand All @@ -151,7 +154,7 @@ export const withToolbarControls = createHigherOrderComponent(
<BlockAlignmentControl
value={ props.attributes.align }
onChange={ updateAlignment }
controls={ blockAllowedAlignments }
controls={ validAlignments }
/>
</BlockControls>
{ blockEdit }
Expand Down

0 comments on commit c7c5549

Please sign in to comment.