Revise getPostMetaChanges to use existing deep comparison

WordPress · Jun 29, 2024 · a9b7067 · a9b7067
1 parent b4405bd
commit a9b7067
Show file tree

Hide file tree

Showing 5 changed files with 10 additions and 26 deletions.
diff --git a/packages/block-editor/src/components/global-styles/get-global-styles-changes.js b/packages/block-editor/src/components/global-styles/get-global-styles-changes.js
@@ -68,7 +68,7 @@ function getTranslation( key ) {
  * @param {string} parentPath     A key/value pair object of block names and their rendered titles.
  * @return {string[]}             An array of paths whose values have changed.
  */
-function deepCompare( changedObject, originalObject, parentPath = '' ) {
+export function deepCompare( changedObject, originalObject, parentPath = '' ) {
 	// We have two non-object values to compare.
 	if ( ! isObject( changedObject ) && ! isObject( originalObject ) ) {
 		/*

diff --git a/packages/editor/src/components/entities-saved-states/entity-record-item.js b/packages/editor/src/components/entities-saved-states/entity-record-item.js
@@ -58,15 +58,13 @@ export default function EntityRecordItem( { record, checked, onChange } ) {
 					onChange={ onChange }
 				/>
 			</PanelRow>
-			{ Object.keys( postMetaChanges ).length > 0 && (
+			{ postMetaChanges.length > 0 && (
 				<div className="entities-saved-states__changes">
 					<p>Post Meta</p>
 					<ul>
-						{ Object.keys( postMetaChanges ).map(
-							( postMetaKey ) => (
-								<li key={ postMetaKey }>{ postMetaKey }</li>
-							)
-						) }
+						{ postMetaChanges.map( ( postMeta ) => (
+							<li key={ postMeta }>{ postMeta }</li>
+						) ) }
 					</ul>
 				</div>
 			) }

diff --git a/packages/editor/src/components/post-publish-button/index.js b/packages/editor/src/components/post-publish-button/index.js
@@ -61,8 +61,7 @@ export class PostPublishButton extends Component {
 			// TODO: Explore how to manage `getPostMetaChanges` and pre-publish workflow properly.
 			if (
 				( hasNonPostEntityChanges ||
-					( Object.keys( postMetaChanges ).length > 0 &&
-						isPublished ) ) &&
+					( postMetaChanges.length > 0 && isPublished ) ) &&
 				setEntitiesSavedStatesCallback
 			) {
 				// The modal for multiple entity saving will open,

diff --git a/packages/editor/src/components/save-publish-panels/index.js b/packages/editor/src/components/save-publish-panels/index.js
@@ -59,10 +59,7 @@ export default function SavePublishPanels( {
 				PostPublishExtension={ PluginPostPublishPanel.Slot }
 			/>
 		);
-	} else if (
-		hasNonPostEntityChanges ||
-		Object.keys( postMetaChanges ).length > 0
-	) {
+	} else if ( hasNonPostEntityChanges || postMetaChanges.length > 0 ) {
 		unmountableContent = (
 			<div className="editor-layout__toggle-entities-saved-states-panel">
 				<Button

diff --git a/packages/editor/src/store/private-selectors.js b/packages/editor/src/store/private-selectors.js
@@ -23,6 +23,7 @@ import {
 import { TEMPLATE_PART_POST_TYPE } from './constants';
 import { getFilteredTemplatePartBlocks } from './utils/get-filtered-template-parts';
 import { getEntityActions as _getEntityActions } from '../dataviews/store/private-selectors';
+import { deepCompare } from '../../../block-editor/src/components/global-styles/get-global-styles-changes';
 
 const EMPTY_INSERTION_POINT = {
 	rootClientId: undefined,
@@ -165,21 +166,10 @@ export const getPostMetaChanges = createRegistrySelector(
 		);
 
 		if ( ! original?.meta || ! edits?.meta ) {
-			return {};
+			return [];
 		}
 
-		const keys = Object.keys( original.meta );
-		const differences = {};
-		for ( const key of keys ) {
-			if ( key === 'footnotes' ) {
-				continue;
-			}
-			if ( original.meta[ key ] !== edits.meta[ key ] ) {
-				differences[ key ] = edits.meta[ key ];
-			}
-		}
-
-		return differences;
+		return deepCompare( edits.meta, original.meta );
 	}
 );