Avoid passing isActive as callback

Since it’s known at time of render
WordPress · May 26, 2017 · 8c42fdd · 8c42fdd
1 parent 630256e
commit 8c42fdd
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 6 deletions.
diff --git a/blocks/block-controls/index.js b/blocks/block-controls/index.js
@@ -9,11 +9,6 @@ import { Fill } from 'react-slot-fill';
 import Toolbar from 'components/toolbar';
 
 export default function BlockControls( { controls } ) {
-	controls = controls.map( ( control ) => ( {
-		...control,
-		isActive: !! control.isActive && control.isActive(),
-	} ) );
-
 	return (
 		<Fill name="Formatting.Toolbar">
 			<Toolbar controls={ controls } />

diff --git a/blocks/library/heading/index.js b/blocks/library/heading/index.js
@@ -87,7 +87,7 @@ registerBlock( 'core/heading', {
 						'123456'.split( '' ).map( ( level ) => ( {
 							icon: 'heading',
 							title: wp.i18n.sprintf( wp.i18n.__( 'Heading %s' ), level ),
-							isActive: () => 'H' + level === nodeName,
+							isActive: 'H' + level === nodeName,
 							onClick: () => setAttributes( { nodeName: 'H' + level } ),
 							subscript: level,
 						} ) )