-
Notifications
You must be signed in to change notification settings - Fork 4.2k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[Experimental]: First version of pages list in site editor (#54966)
* [Experimental]: First version of pages list in site editor * remove DataViewsContext and SidebarNavigationScreenPagesList * add sorting controls in view actions
- Loading branch information
1 parent
296aa21
commit 7576b9c
Showing
17 changed files
with
886 additions
and
6 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,60 @@ | ||
/** | ||
* External dependencies | ||
*/ | ||
import { | ||
getCoreRowModel, | ||
getFilteredRowModel, | ||
getSortedRowModel, | ||
getPaginationRowModel, | ||
useReactTable, | ||
} from '@tanstack/react-table'; | ||
|
||
/** | ||
* WordPress dependencies | ||
*/ | ||
import { | ||
__experimentalVStack as VStack, | ||
__experimentalHStack as HStack, | ||
} from '@wordpress/components'; | ||
|
||
/** | ||
* Internal dependencies | ||
*/ | ||
import ListView from './list-view'; | ||
import { Pagination } from './pagination'; | ||
import ViewActions from './view-actions'; | ||
import TextFilter from './text-filter'; | ||
|
||
export default function DataViews( { | ||
data, | ||
fields, | ||
isLoading, | ||
paginationInfo, | ||
options, | ||
} ) { | ||
const dataView = useReactTable( { | ||
data, | ||
columns: fields, | ||
...options, | ||
getCoreRowModel: getCoreRowModel(), | ||
getFilteredRowModel: getFilteredRowModel(), | ||
getSortedRowModel: getSortedRowModel(), | ||
getPaginationRowModel: getPaginationRowModel(), | ||
} ); | ||
return ( | ||
<div className="dataviews-wrapper"> | ||
<VStack spacing={ 4 }> | ||
<HStack justify="space-between"> | ||
<TextFilter onChange={ dataView.setGlobalFilter } /> | ||
<ViewActions dataView={ dataView } /> | ||
</HStack> | ||
{ /* This component will be selected based on viewConfigs. Now we only have the list view. */ } | ||
<ListView dataView={ dataView } isLoading={ isLoading } /> | ||
<Pagination | ||
dataView={ dataView } | ||
totalItems={ paginationInfo?.totalItems } | ||
/> | ||
</VStack> | ||
</div> | ||
); | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
export { default as DataViews } from './dataviews'; | ||
export { PAGE_SIZE_VALUES } from './view-actions'; |
106 changes: 106 additions & 0 deletions
106
packages/edit-site/src/components/dataviews/list-view.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,106 @@ | ||
/** | ||
* External dependencies | ||
*/ | ||
import classnames from 'classnames'; | ||
import { flexRender } from '@tanstack/react-table'; | ||
|
||
/** | ||
* WordPress dependencies | ||
*/ | ||
import { __ } from '@wordpress/i18n'; | ||
import { chevronDown, chevronUp } from '@wordpress/icons'; | ||
import { Button } from '@wordpress/components'; | ||
import { forwardRef } from '@wordpress/element'; | ||
|
||
const sortIcons = { asc: chevronUp, desc: chevronDown }; | ||
function Header( { header } ) { | ||
if ( header.isPlaceholder ) { | ||
return null; | ||
} | ||
const text = flexRender( | ||
header.column.columnDef.header, | ||
header.getContext() | ||
); | ||
if ( ! header.column.getCanSort() ) { | ||
return text; | ||
} | ||
const sortDirection = header.column.getIsSorted(); | ||
return ( | ||
<Button | ||
onClick={ header.column.getToggleSortingHandler() } | ||
icon={ sortIcons[ sortDirection ] } | ||
iconPosition="right" | ||
text={ text } | ||
style={ { padding: 0 } } | ||
/> | ||
); | ||
} | ||
|
||
function ListView( { dataView, className, isLoading = false }, ref ) { | ||
const { rows } = dataView.getRowModel(); | ||
const hasRows = !! rows?.length; | ||
if ( isLoading ) { | ||
// TODO:Add spinner or progress bar.. | ||
return <h3>{ __( 'Loading' ) }</h3>; | ||
} | ||
return ( | ||
<div className="dataviews-list-view-wrapper"> | ||
{ hasRows && ( | ||
<table | ||
ref={ ref } | ||
className={ classnames( 'dataviews-list-view', className ) } | ||
> | ||
<thead> | ||
{ dataView.getHeaderGroups().map( ( headerGroup ) => ( | ||
<tr key={ headerGroup.id }> | ||
{ headerGroup.headers.map( ( header ) => ( | ||
<th | ||
key={ header.id } | ||
colSpan={ header.colSpan } | ||
style={ { | ||
width: | ||
header.column.columnDef.width || | ||
undefined, | ||
maxWidth: | ||
header.column.columnDef | ||
.maxWidth || undefined, | ||
} } | ||
> | ||
<Header header={ header } /> | ||
</th> | ||
) ) } | ||
</tr> | ||
) ) } | ||
</thead> | ||
<tbody> | ||
{ rows.map( ( row ) => ( | ||
<tr key={ row.id }> | ||
{ row.getVisibleCells().map( ( cell ) => ( | ||
<td | ||
key={ cell.id } | ||
style={ { | ||
width: | ||
cell.column.columnDef.width || | ||
undefined, | ||
maxWidth: | ||
cell.column.columnDef | ||
.maxWidth || undefined, | ||
} } | ||
> | ||
{ flexRender( | ||
cell.column.columnDef.cell, | ||
cell.getContext() | ||
) } | ||
</td> | ||
) ) } | ||
</tr> | ||
) ) } | ||
</tbody> | ||
</table> | ||
) } | ||
{ ! hasRows && <p>{ __( 'no results' ) }</p> } | ||
</div> | ||
); | ||
} | ||
|
||
export default forwardRef( ListView ); |
Oops, something went wrong.
7576b9c
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Flaky tests detected in 7576b9c.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.
🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/6405386832
📝 Reported issues:
/test/e2e/specs/editor/various/multi-block-selection.spec.js