Skip to content

Commit

Permalink
Update the editor landmark regions (#24196)
Browse files Browse the repository at this point in the history
  • Loading branch information
youknowriad committed Jul 27, 2020
1 parent 2a8872c commit 6d5c06c
Show file tree
Hide file tree
Showing 2 changed files with 13 additions and 3 deletions.
4 changes: 2 additions & 2 deletions packages/e2e-tests/specs/experiments/navigation.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -335,7 +335,7 @@ describe( 'Navigation', () => {
// Scope element selector to the Editor's "Content" region as otherwise it picks up on
// block previews.
const navBlockItemsLength = await page.$$eval(
'[aria-label="Content"][role="region"] li[aria-label="Block: Link"]',
'[aria-label="Editor content"][role="region"] li[aria-label="Block: Link"]',
( els ) => els.length
);

Expand All @@ -361,7 +361,7 @@ describe( 'Navigation', () => {
// Scope element selector to the "Editor content" as otherwise it picks up on
// Block Style live previews.
const navBlockItemsLength = await page.$$eval(
'[aria-label="Content"][role="region"] li[aria-label="Block: Link"]',
'[aria-label="Editor content"][role="region"] li[aria-label="Block: Link"]',
( els ) => els.length
);

Expand Down
12 changes: 11 additions & 1 deletion packages/edit-post/src/components/layout/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,17 @@ import WelcomeGuide from '../welcome-guide';
import ActionsPanel from './actions-panel';

const interfaceLabels = {
leftSidebar: __( 'Block Library' ),
leftSidebar: __( 'Block library' ),
/* translators: accessibility text for the editor top bar landmark region. */
header: __( 'Editor top bar' ),
/* translators: accessibility text for the editor content landmark region. */
body: __( 'Editor content' ),
/* translators: accessibility text for the editor settings landmark region. */
sidebar: __( 'Editor settings' ),
/* translators: accessibility text for the editor publish landmark region. */
actions: __( 'Editor publish' ),
/* translators: accessibility text for the editor footer landmark region. */
footer: __( 'Editor footer' ),
};

function Layout() {
Expand Down

0 comments on commit 6d5c06c

Please sign in to comment.