incorporate initial feedback

WordPress · Nov 3, 2023 · 6aa72d6 · 6aa72d6
1 parent c11a67f
commit 6aa72d6
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 15 deletions.
diff --git a/packages/edit-post/src/components/sidebar/settings-header/index.js b/packages/edit-post/src/components/sidebar/settings-header/index.js
@@ -33,23 +33,23 @@ const SettingsHeader = ( { sidebarName } ) => {
 		};
 	}, [] );
 
-	const [ documentAriaLabel ] =
+	const documentAriaLabel =
 		sidebarName === 'edit-post/document'
 			? // translators: ARIA label for the Document sidebar tab, selected. %s: Document label.
-			  [ sprintf( __( '%s (selected)' ), documentLabel ), 'is-active' ]
-			: [ documentLabel, '' ];
+			  sprintf( __( '%s (selected)' ), documentLabel )
+			: documentLabel;
 
-	const [ blockAriaLabel ] =
+	const blockAriaLabel =
 		sidebarName === 'edit-post/block'
 			? // translators: ARIA label for the Block Settings Sidebar tab, selected.
-			  [ __( 'Block (selected)' ), 'is-active' ]
+			  __( 'Block (selected)' )
 			: // translators: ARIA label for the Block Settings Sidebar tab, not selected.
-			  [ __( 'Block' ), '' ];
+			  __( 'Block' );
 
-	const [ templateAriaLabel ] =
+	const templateAriaLabel =
 		sidebarName === 'edit-post/document'
-			? [ __( 'Template (selected)' ), 'is-active' ]
-			: [ __( 'Template' ), '' ];
+			? __( 'Template (selected)' )
+			: __( 'Template' );
 
 	return (
 		<>
@@ -60,14 +60,12 @@ const SettingsHeader = ( { sidebarName } ) => {
 						isTemplateMode ? (
 							<Button
 								onClick={ openDocumentSettings }
-								className={ `edit-post-sidebar__panel-tab` }
 								aria-label={ templateAriaLabel }
 								data-label={ __( 'Template' ) }
 							/>
 						) : (
 							<Button
 								onClick={ openDocumentSettings }
-								className={ `edit-post-sidebar__panel-tab` }
 								aria-label={ documentAriaLabel }
 								data-label={ documentLabel }
 							/>
@@ -81,13 +79,10 @@ const SettingsHeader = ( { sidebarName } ) => {
 					render={
 						<Button
 							onClick={ openBlockSettings }
-							className={ `edit-post-sidebar__panel-tab` }
 							aria-label={ blockAriaLabel }
 							// translators: Data label for the Block Settings Sidebar tab.
 							data-label={ __( 'Block' ) }
-						>
-							{  }
-						</Button>
+						/>
 					}
 				>
 					{ /* translators: Text label for the Block Settings Sidebar tab. */ }

diff --git a/packages/edit-post/src/components/sidebar/settings-sidebar/index.js b/packages/edit-post/src/components/sidebar/settings-sidebar/index.js
@@ -74,6 +74,9 @@ const SettingsSidebar = () => {
 	);
 
 	const Content = () => {
+		// Because `PluginSidebarEditPost` renders a `ComplementaryArea`, we
+		// need to forward the `Tabs` context so it can be passed through the
+		// underlying slot/fill.
 		const tabsContextValue = useContext( Tabs.Context );
 
 		return (