Skip to content

Commit

Permalink
Components: refactor FontSizePicker to pass exhaustive-deps (#41600)
Browse files Browse the repository at this point in the history
* FontSizePicker: add missing `useMemo` dependencies

* FontSizePicker: update changelog
  • Loading branch information
chad1008 authored Jun 9, 2022
1 parent 05e05ae commit 57cb200
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 1 deletion.
1 change: 1 addition & 0 deletions packages/components/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
- `Flex` updated to satisfy `react/exhuastive-deps` eslint rule ([#41507](https://github.com/WordPress/gutenberg/pull/41507)).
- `CustomGradientBar` updated to satisfy `react/exhuastive-deps` eslint rule ([#41463](https://github.com/WordPress/gutenberg/pull/41463))
- `TreeSelect`: Convert to TypeScript ([#41536](https://github.com/WordPress/gutenberg/pull/41536)).
- `FontSizePicker`: updated to satisfy `react/exhuastive-deps` eslint rule ([#41600](https://github.com/WordPress/gutenberg/pull/41600)).


## 19.12.0 (2022-06-01)
Expand Down
4 changes: 3 additions & 1 deletion packages/components/src/font-size-picker/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -103,9 +103,11 @@ function FontSizePicker(
return hint;
}, [
showCustomValueControl,
selectedOption?.slug,
selectedOption?.name,
selectedOption?.size,
value,
isCustomValue,
shouldUseSelectControl,
fontSizesContainComplexValues,
] );

Expand Down

0 comments on commit 57cb200

Please sign in to comment.