-
Notifications
You must be signed in to change notification settings - Fork 4.2k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Shortcode: Prevent external styling of editing UI (#49723)
* Shortcode: Prevent external styling of editing UI * Disable resizing
- Loading branch information
Showing
1 changed file
with
26 additions
and
5 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,13 +1,34 @@ | ||
[data-type="core/shortcode"] { | ||
.block-editor-plain-text { | ||
max-height: 250px; | ||
} | ||
|
||
&.components-placeholder { | ||
min-height: 0; | ||
} | ||
} | ||
|
||
// The editing view for the Shortcode block is equivalent to block UI. | ||
// Therefore we increase specificity to avoid theme styles bleeding in. | ||
.blocks-shortcode__textarea { | ||
@include input-control; | ||
font-family: $editor-html-font !important; | ||
color: $gray-900 !important; | ||
background: $white !important; | ||
padding: $grid-unit-15 !important; | ||
border: $border-width solid $gray-900 !important; | ||
box-shadow: none !important; | ||
border-radius: $radius-block-ui !important; | ||
box-sizing: border-box; | ||
max-height: 250px; | ||
resize: none; | ||
|
||
/* Fonts smaller than 16px causes mobile safari to zoom. */ | ||
font-size: $mobile-text-min-font-size !important; | ||
@include break-small { | ||
font-size: $default-font-size !important; | ||
} | ||
|
||
&:focus { | ||
border-color: var(--wp-admin-theme-color) !important; | ||
box-shadow: 0 0 0 ($border-width-focus - $border-width) var(--wp-admin-theme-color) !important; | ||
|
||
// Windows High Contrast mode will show this outline, but not the box-shadow. | ||
outline: 2px solid transparent !important; | ||
} | ||
} |
293ea89
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Flaky tests detected in 293ea89.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.
🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4676986856
📝 Reported issues:
specs/site-editor/settings-sidebar.test.js