Skip to content

Commit

Permalink
Build: remove global install of latest npm since we want to use the p…
Browse files Browse the repository at this point in the history
…aired node/npm version (#17134)

* Build: remove global install of latest npm since we want to use the paired node/npm version
* Also update travis to remove --latest-npm flag
  • Loading branch information
gwwar authored and gziolo committed Aug 29, 2019
1 parent 4868a8b commit 10b1a72
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 4 deletions.
2 changes: 1 addition & 1 deletion .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ branches:
- master

before_install:
- nvm install --latest-npm
- nvm install

env: PUPPETEER_SKIP_CHROMIUM_DOWNLOAD=true

Expand Down
3 changes: 0 additions & 3 deletions bin/install-node-nvm.sh
Original file line number Diff line number Diff line change
Expand Up @@ -69,9 +69,6 @@ fi
echo -e $(status_message "Installing and updating NPM packages..." )
npm install

# Make sure npm is up-to-date
npm install npm -g

# There was a bug in NPM that caused changes in package-lock.json. Handle that.
if [ "$TRAVIS" != "true" ] && ! git diff --no-ext-diff --exit-code package-lock.json >/dev/null; then
if ask "$(warning_message "Your package-lock.json changed, which may mean there's an issue with your NPM cache. Would you like to try and automatically clean it up?" )" N 10; then
Expand Down

0 comments on commit 10b1a72

Please sign in to comment.