Add icon for Unlink and Shortcode #269
Conversation
Unlink is the reverse of link. What it does on click is to _break a link_, unlink it, stop it from being a link. Requested by @karmatosed for an iteration on the link interface. The other icon is for shortcodes. Fixes #261. It's for the shortcode block.
|
Can we "flatten" the top and bottom edges of the slash in the shortcodes icon? |
|
Also, is this unlink meant to replace what we already have? See https://developer.wordpress.org/resource/dashicons/#editor-unlink |
|
Yes, I'll flatten the top and bottom edges of the slash, and oh my — I didn't realize that there was already an unlink icon — looks like Tammie missed that too. I believe the request was on the Gutenberg Github. I'm afk next week, but maybe I'll tweak this PR today real quick to address your feedback and to remove the unlink icon. |
|
How's that? Also, removed the unlink icon. |
|
Looks good, but will this conflict with the PR I just did? |
|
Yes but if you give me a thumbs up I will rebase, fix, and merge 🙂 |
|
Per discussion in https://wordpress.slack.com/archives/C03EESJAW/p1519836029000445 and based on your "looks good", I'm goign to merge this, rebase #274, and merge that after. |
Unlink is the reverse of link. What it does on click is to break a link, unlink it, stop it from being a link. Requested by @karmatosed for an iteration on the link interface.
The other icon is for shortcodes. Fixes #261. It's for the shortcode block.