Fix documentation anti-patterns and REST API security vulnerability #93
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…per maintainer feedback
Replace 22-line manual permission checking anti-pattern with clean 8-line execute() approach per @justlevine feedback. This eliminates the security risk of teaching developers complex permission workflows that can introduce WP_Error truthiness bugs.
… examples - Remove manual check_permission() before execute() examples - Add clean execute() → is_wp_error() pattern throughout - Include advanced error handling with ability_invalid_permissions - Fix variable name bug in first example - Eliminate confusing method signature that contradicted guidance - Address all @justlevine feedback about promoting execute() over manual checks
Change permission check from loose to strict comparison in run_ability_permissions_check(). The previous pattern `if ( ! $ability->check_permission( $input ) )` would incorrectly pass WP_Error objects as truthy, potentially allowing unauthorized access. Fixed by using `if ( true !== $ability->check_permission( $input ) )` to properly handle both false and WP_Error return values.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Unlinked AccountsThe following contributors have not linked their GitHub and WordPress.org accounts: @[email protected]. Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases. If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes Made
Documentation Fixes
Security Fix
Test plan