Introduce invoke_callback helper method in WP_Ability class

[gziolo]

This PR introduces a new invoke_callback helper method in the WP_Ability class to standardize callback invocation logic. The method handles whether to pass input parameters based on the presence of an input schema, replacing duplicated logic in the permission and execution callback methods. Additional test coverage was added to ensure that functionality continues to work the same way.

You can run tests locally with:

npm run test:php

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.26%. Comparing base (56616ba) to head (bb6aaf0).
⚠️ Report is 1 commits behind head on trunk.

Additional details and impacted files

@@             Coverage Diff              @@
##              trunk      #88      +/-   ##
============================================
+ Coverage     86.24%   86.26%   +0.01%     
  Complexity      110      110              
============================================
  Files            16       16              
  Lines           807      808       +1     
  Branches         86       86              
============================================
+ Hits            696      697       +1     
  Misses          111      111              

Flag	Coverage Δ
javascript	92.62% <ø> (ø)
unit	83.92% <100.00%> (+0.02%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[Copilot]

Pull Request Overview

This PR introduces a new invoke_callback helper method in the WP_Ability class to standardize callback invocation logic. The method handles whether to pass input parameters based on the presence of an input schema, replacing duplicated logic in the permission and execution callback methods.

• Adds a new protected invoke_callback helper method to centralize callback invocation logic
• Refactors check_permissions and do_execute methods to use the new helper
• Adds comprehensive test coverage for different callback types (functions, closures, static methods, instance methods)

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File	Description
includes/abilities-api/class-wp-ability.php	Introduces invoke_callback helper method and refactors existing methods to use it
tests/unit/abilities-api/wpAbility.php	Adds test methods and data provider to verify callback handling with different callable types

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

[github-actions]

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: gziolo <[email protected]>
Co-authored-by: JasonTheAdams <[email protected]>
Co-authored-by: felixarntz <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

[JasonTheAdams]

Nice little refactor! I made a minor suggestion, but it's small enough where I'll approve regardless of your decision.

[JasonTheAdams]

While we're cleaning things up, what do you think about adding a $this->has_input_schema() method to make this sort of check more declarative?

[gziolo]

Sounds like a good idea 👍

[gziolo]

I will play with this, and the other method idea #104 (comment) in a follow-up PR 😄

[gziolo]

Would it make sense to have a similar method for the output schema? Given all the other tasks necessary for WP 6.9, this one is nice to have we can introduce later.

[felixarntz]

@gziolo Good idea, LGTM!