Add code quality improvements to code comments #47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gziolo
changed the title
gziolo
force-pushed
the
fix/improve-code-quality
branch
from
38686eb to
8e8999a
Compare
justlevine
reviewed
Aug 27, 2025
justlevine
approved these changes
Aug 27, 2025
There was a problem hiding this comment.
lgtm
(To accommodate the dual falsy false|WP_Error return values, we're gonna want to make sure that usage and docs use if ( true === $ability->has_permissions() ) and not e.g. the shorthand if ( $ability->has_permissions() ) which will also return true for a WP_Error.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code quality improvements extracted from #37.
CI checks should pass here.
CI checks should pass also for the code tested agains WordPress core in WordPress/wordpress-develop#9410.