-
Notifications
You must be signed in to change notification settings - Fork 28
Move show_in_rest
to meta in the registration process
#107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## trunk #107 +/- ##
============================================
+ Coverage 86.17% 86.27% +0.10%
- Complexity 110 111 +1
============================================
Files 16 16
Lines 803 809 +6
Branches 86 86
============================================
+ Hits 692 698 +6
Misses 111 111
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
9c425f5
to
8f937a6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking mostly good, just one question on the default, @gziolo.
8f937a6
to
583da4c
Compare
Co-authored-by: Dovid Levine <[email protected]>
Co-authored-by: Dovid Levine <[email protected]>
Co-authored-by: Dovid Levine <[email protected]>
055a87b
to
fee5c3c
Compare
The decision was made in #107 (comment) to keep |
fee5c3c
to
207146e
Compare
Move
show_in_rest
tometa
in the registration process.Example:
I also included the proposal in 8f937a6 to change the default value toThe decision was made in #107 (comment) to keeptrue
, so all abilities are exposed in REST API by default.show_in_rest
defaulting tofalse
.I also replaced
show_in_rest()
method with a more generalized helperget_meta_item()
. Example usage: