Sniff::is_token_in_test_method(): allow for anonymous classes#1456
Merged
Sniff::is_token_in_test_method(): allow for anonymous classes#1456
Conversation
* Allow for anonymous classes. * Examine all OO conditions a function is nested in for whether or not they are or extend test classes.
…traits Includes unit tests.
JDGrimes
approved these changes
Aug 24, 2018
GaryJones
deleted the
feature/test-skipping-allow-for-anonymous-classes
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While since #883, the
Sniff::is_test_class()method already allowed for anonymous classes, theSniff::is_token_in_test_method()did not.Also, as OO structures can be nested in PHP, all relevant structures within which the test method is nested should be examined, not just the first encountered.
Note: examination of nested extended classes based on the class they extend is currently afflicted by a bug in PHPCS itself. I expect the bugfix I pulled for that to be included in the 3.3.2 release.
See: squizlabs/PHP_CodeSniffer#2127
This PR also adjusts the
PrefixAllGlobalssniff to allow for anonymous test classes and traits extending test classes. Includes unit tests for this particular change.