Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change "Request" to "Requests" in deprecation message. #785

Conversation

costdev
Copy link
Contributor

@costdev costdev commented Dec 17, 2022

There is a minor typo in library/Requests.php, src/Autoload.php and the test file tests/Autoload/AutoloadTest.php.

The PSR-0 Requests_... class names in the Request library are deprecated.

"Request" should be "Requests".

Pull Request Type

  • I have checked there is no other PR open for the same change.

This is a:

  • Bug fix
  • New feature
  • Code quality improvement

Quality assurance

  • This change does NOT contain a breaking change (fix or feature that would cause existing functionality to change).

Copy link
Member

@jrfnl jrfnl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching that @costdev!

I believe there is one more place which needs adjusting:

'The PSR-0 `Requests_...` class names in the Request library are deprecated.'

@jrfnl jrfnl added this to the 2.1.0 milestone Dec 17, 2022
@costdev costdev force-pushed the typo/Request_to_Requests_in_deprecation_notice branch from db0ca7b to 93916eb Compare December 17, 2022 12:55
@costdev
Copy link
Contributor Author

costdev commented Dec 17, 2022

Done and force-pushed. 🙂

Copy link
Member

@jrfnl jrfnl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Colin!

@jrfnl
Copy link
Member

jrfnl commented Dec 17, 2022

Side-note: if we would release a 2.0.x version prior to the 2.1.0 release, I'd like to suggest cherrypicking this commit into the 2.0.x release.

@schlessera schlessera mentioned this pull request Jan 9, 2023
1 task
@schlessera schlessera merged commit b1b5c73 into WordPress:develop Jan 9, 2023
@schlessera schlessera modified the milestones: 2.1.0, 2.0.6 Apr 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants