Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add cookie support #64

Merged
merged 13 commits into from
Sep 24, 2013
Merged

Add cookie support #64

merged 13 commits into from
Sep 24, 2013

Commits on Aug 18, 2013

  1. First pass at cookie support 

    Still needs tests.
    @rmccue
    rmccue committed Aug 18, 2013
    Configuration menu
    Copy the full SHA
    c53bc19 View commit details
    Browse the repository at this point in the history

  2. Trim all cookie keys and values

    @rmccue
    rmccue committed Aug 18, 2013
    Configuration menu
    Copy the full SHA
    ee0ea00 View commit details
    Browse the repository at this point in the history

Commits on Sep 24, 2013

  1. Ensure casting a cookie to a string uses the value

    @rmccue
    rmccue committed Sep 24, 2013
    Configuration menu
    Copy the full SHA
    2be3484 View commit details
    Browse the repository at this point in the history

  2. Implement the array-like interfaces for Cookie_Jar

    @rmccue
    rmccue committed Sep 24, 2013
    Configuration menu
    Copy the full SHA
    31d2e64 View commit details
    Browse the repository at this point in the history

  3. Always attach a cookie jar to a request

    @rmccue
    rmccue committed Sep 24, 2013
    Configuration menu
    Copy the full SHA
    e7462d1 View commit details
    Browse the repository at this point in the history

  4. Use the correct jar property

    @rmccue
    rmccue committed Sep 24, 2013
    Configuration menu
    Copy the full SHA
    ffdcc79 View commit details
    Browse the repository at this point in the history

  5. Use an existing key if we have one 

    This allows passing in [ 'a' => 'b' ] rather than just [ 'a=b' ]
    @rmccue
    rmccue committed Sep 24, 2013
    Configuration menu
    Copy the full SHA
    996a32c View commit details
    Browse the repository at this point in the history

  6. Store cookies in a flat array 

    I was a little overzealous here; cookies can only have a single value.
    @rmccue
    rmccue committed Sep 24, 2013
    Configuration menu
    Copy the full SHA
    3dbca26 View commit details
    Browse the repository at this point in the history

  7. Persist cookies between requests 

    Adds a new 'requests.before_redirect_check' hook to allow for this.
    @rmccue
    rmccue committed Sep 24, 2013
    Configuration menu
    Copy the full SHA
    3d05c4c View commit details
    Browse the repository at this point in the history

  8. Use instanceof instead of is_a 

    is_a was deprecated from 5.0-5.3, plus it takes parameters in the opposite order
to what the code previously had.
    @rmccue
    rmccue committed Sep 24, 2013
    Configuration menu
    Copy the full SHA
    72369f7 View commit details
    Browse the repository at this point in the history

  9. Properly parse non-associative cookie attributes 

    Output too.
    @rmccue
    rmccue committed Sep 24, 2013
    Configuration menu
    Copy the full SHA
    49c9fd4 View commit details
    Browse the repository at this point in the history

  10. Change CaseInsensitiveDictionary to be flat 

    Moves all multiple-value handling back to the headers class.
    @rmccue
    rmccue committed Sep 24, 2013
    Configuration menu
    Copy the full SHA
    136fee6 View commit details
    Browse the repository at this point in the history

  11. Add testing for cookie parsing

    @rmccue
    rmccue committed Sep 24, 2013
    Configuration menu
    Copy the full SHA
    485927a View commit details
    Browse the repository at this point in the history