PHP 8.0 | Hooks::dispatch(): prevent potential fatal error #599
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schlessera
reviewed
Nov 8, 2021
This commit adds a safeguard on the off-chance that the `Hooks::dispatch()` method would ever be called with an associative array for the parameters. This prevents a potential fatal `Unknown named parameter ...` error in PHP 8.x. Includes unit test.
jrfnl
force-pushed
the
feature/php-8.0-named-params-call-user-func-array
branch
from
90dae9b
to
7d5014d
Compare
... by replacing the `call_user_func_array()` with a variable function call in combination with the spread operator. Includes adding a dedicated test to safeguard that this change does not break the handling of references when passed as part of the `$parameters` to dispatch.
jrfnl
force-pushed
the
feature/php-8.0-named-params-call-user-func-array
branch
from
7d5014d
to
5926bb1
Compare
|
FYI: re-pushed commit has no functional changes, just added the |
schlessera
approved these changes
Nov 10, 2021
schlessera
deleted the
feature/php-8.0-named-params-call-user-func-array
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PHP 8.0 | Hooks::dispatch(): prevent potential fatal error
This commit adds a safeguard on the off-chance that the
Hooks::dispatch()method would ever be called with an associative array for the parameters.This prevents a potential fatal
Unknown named parameter ...error in PHP 8.x.Includes unit test.
Related to #533
🆕 Hooks::dispatch(): modernize dynamic function call
... by replacing the
call_user_func_array()with a variable function call in combination with the spread operator.Includes adding a dedicated test to safeguard that this change does not break the handling of references when passed as part of the
$parametersto dispatch.