PHP 8.0: ensure parameter names are aligned with PHP native param names #560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es [1] ... for the required methods declared in classes implementing the `ArrayAccess` interface, either directly or by extending a class which implements the interface. This prevents issues with when the PHP 8.0 named parameters feature is used. Refs: * https://www.php.net/manual/en/class.arrayaccess.php * https://wiki.php.net/rfc/named_params
With the `$key` parameters being changed to `$offset` in the previous commit, for consistency, it makes the code clearer to use the same name in other places in these classes which also use the `$offset`, but were calling it `$key`.
…es [2] ... for the magic `__unserialize()` method and the `serialize()` method which is overloaded from the extended `ArrayIterator` class. This prevents issues with when the PHP 8.0 named parameters feature is used. Refs: * https://www.php.net/manual/en/class.arrayiterator.php * https://www.php.net/manual/en/language.oop5.magic.php#object.unserialize * https://wiki.php.net/rfc/named_params
schlessera
approved these changes
Sep 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PHP 8.0: ensure parameter names are aligned with PHP native param names [1]
... for the required methods declared in classes implementing the
ArrayAccessinterface, either directly or by extending a class which implements the interface.This prevents issues with when the PHP 8.0 named parameters feature is used.
Refs:
QA: use consistent param/variable names throughout classes
With the
$keyparameters being changed to$offsetin the previous commit, for consistency, it makes the code clearer to use the same name in other places in these classes which also use the$offset, but were calling it$key.PHP 8.0: ensure parameter names are aligned with PHP native param names [2]
... for the magic
__unserialize()method and theserialize()method which is overloaded from the extendedArrayIteratorclass.This prevents issues with when the PHP 8.0 named parameters feature is used.
Refs:
Related to #533