Exception\Http\StatusUnknown: add perfunctory unit tests #552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The default value of the `Requests\Response::$status_code` property is `false` and that value is also meant to be used for non-blocking errors. If, in that case, as `StatusUnknown` error would be thrown, the `$error_code` for the Exception would be set to the invalid value `false`, while this should always be an integer. Fixed now.
schlessera
approved these changes
Sep 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exception\Http\StatusUnknown: add perfunctory unit test
Exception\Http\StatusUnknown: minor bug fix
The default value of the
Requests\Response::$status_codeproperty isfalseand that value is also meant to be used for non-blocking errors.If, in that case, as
StatusUnknownerror would be thrown, the$error_codefor the Exception would be set to the invalid valuefalse, while this should always be an integer.Fixed now.
Related to #497