Various minor docs fixes #543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This method does not throw.
... which was clearly unfinished.
The PHP Curl extension worked with a Curl resource in PHP 4/5/7. As of PHP 8.0, `curl_init()` returns an instance of `CurlHandle` instead of a resource. This updates the documentation to indicate that either a `resource` or `CurlHandle` instance can be expected in certain places in the code base (and that both are supported). Ref: https://www.php.net/manual/en/migration80.incompatible.php#migration80.incompatible.resource2object
schlessera
approved these changes
Sep 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Docs: remove stray unicode character from docs
Ssl: remove incorrect @throws tag
This method does not throw.
Docs: add missing @return tags
Docs: add missing method docblock
Headers::getIterator() fix up comment in docblock
... which was clearly unfinished.
Documentation: fix minor grammar error
Documentation: fix references to Curl resources
The PHP Curl extension worked with a Curl resource in PHP 4/5/7. As of PHP 8.0,
curl_init()returns an instance ofCurlHandleinstead of a resource.This updates the documentation to indicate that either a
resourceorCurlHandleinstance can be expected in certain places in the code base (and that both are supported).Ref: https://www.php.net/manual/en/migration80.incompatible.php#migration80.incompatible.resource2object