GH Actions: run tests against PHP 8.1 #501
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There's something weird going on here as the PHP 8.1 build should show 16 failing tests... I've opened an issue with the Setup PHP action runner: shivammathur/setup-php#469 |
jrfnl
force-pushed
the
feature/498-ghactions-add-build-against-php-8.1
branch
from
f6c61d2
to
980b3e3
Compare
jrfnl
force-pushed
the
feature/498-ghactions-add-build-against-php-8.1
branch
from
980b3e3
to
7759ca8
Compare
|
New issues introduced in PHP 8.1.0-beta1 are addressed in PR #505 |
schlessera
approved these changes
Jul 30, 2021
jrfnl
force-pushed
the
feature/498-ghactions-add-build-against-php-8.1
branch
from
7759ca8
to
2997268
Compare
Now PR 446 has been merged and the PHPUnit version requirements widened, we can start running the tests against PHP 8.1. For the time being - until PHP 8.1 is actually released - these builds are allowed to fail (experimental), though fixing as much as possible as soon as possible, would be a good idea ;-) Fixes 498
Turns out the default setting for `error_reporting` used by the SetupPHP action is `error_reporting=E_ALL & ~E_DEPRECATED & ~E_STRICT` and `display_errors` is set to `Off`. For the purposes of CI, I'd recommend running with `E_ALL` and `display_errors=On` to ensure **all** PHP notices are shown.
jrfnl
force-pushed
the
feature/498-ghactions-add-build-against-php-8.1
branch
from
2997268
to
1bb0e93
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now PR #446 has been merged and the PHPUnit version requirements widened, we can start running the tests against PHP 8.1.
For the time being - until PHP 8.1 is actually released - these builds are allowed to fail (experimental), though fixing as much as possible as soon as possible, would be a good idea ;-)
Fixes #498
Edit: I've added a second commit.
GH Actions: set error reporting to E_ALL
Turns out the default setting for
error_reportingused by the SetupPHP action iserror_reporting=E_ALL & ~E_DEPRECATED & ~E_STRICTanddisplay_errorsis set toOff.For the purposes of CI, I'd recommend running with
E_ALLanddisplay_errors=Onto ensure all PHP notices are shown.