Commits on Jun 21, 2021

1. PHP 8.1: fix deprecation notices in Requests_Transport_cURL …

   The `Requests_Transport_cURL:;setup_handle()` and `Requests_Transport_cURL::format_get()` methods, both call the PHP native `http_build_query()` function.
   The second parameter of which is the _optional_ `$numeric_prefix` parameter which expects a `string`.
   
   A parameter being optional, however, does not automatically make it nullable.
   
   As of PHP 8.1, passing `null` to a non-nullable PHP native function will generate a deprecation notice.
   In this case, both these function calls yielded a `http_build_query(): Passing null to parameter #2 ($numeric_prefix) of type string is deprecated` notice.
   
   Changing the `null` to an empty string fixes this without BC-break.
   
   This change is already covered by tests as 15 of the existing tests failed on these function calls when running the tests on PHP 8.1.
   
   Refs:
   * https://www.php.net/manual/en/function.http-build-query.php
   * https://wiki.php.net/rfc/deprecate_null_to_scalar_internal_arg

   

   jrfnl committed Jun 21, 2021
   Configuration menu

   • View commit details
   • Copy full SHA for ba05144
   • Browse repository at this point

   Copy the full SHA

   ba05144 View commit details

   Browse the repository at this point in the history