Add .editorconfig file #491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrfnl
reviewed
Jun 18, 2021
There was a problem hiding this comment.
I'm happy to merge this if it helps people. Not fussed myself as my editor doesn't use the file.
Review Notes:
Not all existing (yml, json) files currently comply with these rules.
Feels to me those should be brought into sync in conjunction with this PR.
I haven't checked the PHP files, but generally speaking that's covered by the CS rules and checked anyhow.
schlessera
force-pushed
the
add/editorconfig-file
branch
from
2723870
to
8187657
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an
.editorconfigfile to let the IDE know how to handle newlines, tabs/spaces, etc. for the project.This avoids commits like this one, as the IDE will automatically deal with this: 228ec26