Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed CURLOPT_REFERER #444

Merged
merged 1 commit into from
Aug 20, 2021
Merged

Removed CURLOPT_REFERER #444

merged 1 commit into from
Aug 20, 2021

Conversation

twdnhfr
Copy link
Contributor

@twdnhfr twdnhfr commented Feb 5, 2021

Hey,

as stated in the curl docs https://everything.curl.dev/libcurl-http/requests#referrer

the Referer is a header that tells the server from which URL the user-agent was directed from.

So imho this shouldn't be the request's target url.

@codecov
Copy link

codecov bot commented Feb 5, 2021

Codecov Report

Merging #444 (009be9c) into master (e50cc34) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #444      +/-   ##
============================================
- Coverage     93.06%   93.06%   -0.01%     
  Complexity      763      763              
============================================
  Files            21       21              
  Lines          1788     1787       -1     
============================================
- Hits           1664     1663       -1     
  Misses          124      124              
Impacted Files Coverage Δ Complexity Δ
library/Requests/Transport/cURL.php 94.68% <ø> (-0.03%) 66.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e50cc34...009be9c. Read the comment docs.

@jrfnl jrfnl changed the base branch from stable to develop June 18, 2021 09:59
Hey,

as stated in the curl docs https://everything.curl.dev/libcurl-http/requests#referrer

the Referer is a header that tells the server from which URL the user-agent was directed from.

So imho this shouldn't be the request's target url.
@jrfnl
Copy link
Member

jrfnl commented Aug 20, 2021

Rebased without changes to make the PR mergable.

@jrfnl jrfnl requested a review from schlessera August 20, 2021 11:00
@jrfnl
Copy link
Member

jrfnl commented Aug 20, 2021

Build failure was a hickup in CI, re-ran the build and it's passing now.

@jrfnl jrfnl added this to the 2.0.0 milestone Aug 20, 2021
@schlessera schlessera merged commit 4f75792 into WordPress:develop Aug 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants