Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Travis: add build against PHP 8.0 #439

Merged
merged 1 commit into from
Mar 20, 2021

Conversation

jrfnl
Copy link
Member

@jrfnl jrfnl commented Dec 4, 2020

PHP 8.0 has been branched off two months ago, so nightly is now PHP 8.1 and in the mean time PHP 8.0 was released last week.

As of today, there is a PHP 8.0 image available on Travis.

This PR adds a new build against PHP 8.0 to the matrix and, as PHP 8.0 has been released, that build is not allowed to fail.

PHP 8.0 has been branched off two months ago, so `nightly` is now PHP 8.1 and in the mean time PHP 8.0 was released last week.

As of today, there is a PHP 8.0 image available on Travis.

This PR adds a new build against PHP 8.0 to the matrix and, as PHP 8.0 has been released, that build is not allowed to fail.
@jrfnl jrfnl force-pushed the feature/travis-test-against-php8-no-failure branch from 5c27bac to 527ab23 Compare March 19, 2021 12:42
@codecov
Copy link

codecov bot commented Mar 19, 2021

Codecov Report

Merging #439 (527ab23) into master (13f258a) will increase coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #439      +/-   ##
============================================
+ Coverage     93.00%   93.06%   +0.05%     
  Complexity      763      763              
============================================
  Files            21       21              
  Lines          1788     1788              
============================================
+ Hits           1663     1664       +1     
+ Misses          125      124       -1     
Impacted Files Coverage Δ Complexity Δ
library/Requests/Transport/fsockopen.php 94.35% <0.00%> (-0.57%) 69.00% <0.00%> (ø%)
library/Requests/Proxy/HTTP.php 100.00% <0.00%> (+6.66%) 13.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 13f258a...527ab23. Read the comment docs.

@schlessera
Copy link
Member

It looks like Travis is not being triggered anymore in this repository. I'm merging this anyway, in case Travis should resurface later.

@schlessera schlessera merged commit 18cc33e into master Mar 20, 2021
@schlessera schlessera deleted the feature/travis-test-against-php8-no-failure branch March 20, 2021 09:50
@schlessera
Copy link
Member

Travis did still run a test build: https://travis-ci.org/github/WordPress/Requests/builds/763695363

@jrfnl
Copy link
Member Author

jrfnl commented Mar 20, 2021

@schlessera Looks like 7.0 failed due to the usual hickups and 8.0 as this PR did not update the condition for when to run composer install with --ignore-platform-reqs.

Other than that, happy to see everything passing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants