Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 7.4 compatibility fix / implode argument order #346

Merged
merged 2 commits into from
Sep 16, 2019
Merged

PHP 7.4 compatibility fix / implode argument order #346

merged 2 commits into from
Sep 16, 2019

Commits on Jul 21, 2019

  1. PHP 7.4 compatibility fix / implode argument order

    `implode()` takes two parameters, `$glue` and `$pieces`.
    For historical reasons, `implode()` accepted these parameters in either order, though it was recommended to use the documented argument order of `implode( $glue, $pieces )`.
    
    PHP 7.4 is slated to deprecate the tolerance for passing the parameters for `implode()` in reverse order.
    PHP 8.0 is expected to remove the tolerance for this completely.
    
    Refs:
    * https://wiki.php.net/rfc/deprecations_php_7_4#implode_parameter_order_mix
    * https://php.net/manual/en/function.implode.php
    jrfnl committed Jul 21, 2019
    Configuration menu
    Copy the full SHA
    7f0b0d7 View commit details
    Browse the repository at this point in the history

Commits on Sep 16, 2019

  1. Configuration menu
    Copy the full SHA
    2aced35 View commit details
    Browse the repository at this point in the history