Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Uppercase the method to ensure compatibility #207

Merged
merged 2 commits into from
Apr 19, 2016
Merged

Uppercase the method to ensure compatibility #207

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
99b5ec1
Uppercase the method to ensure compatibility
rmccue Apr 19, 2016
0158da5
Move $type adjustments to before we check it
rmccue Apr 19, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions library/Requests.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -572,6 +572,9 @@ protected static function set_defaults(&$url, &$headers, &$data, &$type, &$optio
$options['data_format'] = 'body';
}
}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

$type var should be changed to uppercase at the start of this function since $type var is used to define data format.
Let me know if you want me to create PR or update it.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

// Massage the type to ensure we support it.
$type = strtoupper($type);
}

/**
Expand Down