Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove sni.velox.ch from the test suite #196

Merged
merged 2 commits into from
Nov 20, 2015
Merged

Remove sni.velox.ch from the test suite #196

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
eb6f4ba
Remove sni.velox.ch from the test suite
rmccue Nov 20, 2015
55378e0
Only send HEAD requests for SSL tests
rmccue Nov 20, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 8 additions & 9 deletions tests/Transport/Base.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -525,40 +525,39 @@ public function testBadDomain() {
return;
}

$request = Requests::get('https://wrong.host.badssl.com/', array(), $this->getOptions());
$request = Requests::head('https://wrong.host.badssl.com/', array(), $this->getOptions());
}

/**
* Test that the transport supports Server Name Indication with HTTPS
*
* sni.velox.ch is used for SNI testing, and the common name is set to
* `*.sni.velox.ch` as such. Without alternate name support, this will fail
* as `sni.velox.ch` is only in the alternate name
* badssl.com is used for SSL testing, and the common name is set to
* `*.badssl.com` as such. Without alternate name support, this will fail
* as `badssl.com` is only in the alternate name
*/
public function testAlternateNameSupport() {
if ($this->skip_https) {
$this->markTestSkipped('SSL support is not available.');
return;
}

$request = Requests::get('https://sni.velox.ch/', array(), $this->getOptions());
$request = Requests::head('https://badssl.com/', array(), $this->getOptions());
$this->assertEquals(200, $request->status_code);
}

/**
* Test that the transport supports Server Name Indication with HTTPS
*
* sni.velox.ch is used for SNI testing, and the common name is set to
* `*.sni.velox.ch` as such. Without SNI support, this will fail. Also tests
* our wildcard support.
* feelingrestful.com (owned by hmn.md and used with permission) points to
* CloudFlare, and will fail if SNI isn't sent.
*/
public function testSNISupport() {
if ($this->skip_https) {
$this->markTestSkipped('SSL support is not available.');
return;
}

$request = Requests::get('https://abc.sni.velox.ch/', array(), $this->getOptions());
$request = Requests::head('https://feelingrestful.com/', array(), $this->getOptions());
$this->assertEquals(200, $request->status_code);
}

Expand Down