Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix PHP 7 compatibility #176

Merged
merged 3 commits into from
Oct 6, 2015
Merged

Fix PHP 7 compatibility #176

merged 3 commits into from
Oct 6, 2015

Commits on Oct 6, 2015

  1. Don't use CURLOPT_FILE 

    We now handle this via the body streaming.
    @rmccue
    rmccue committed Oct 6, 2015
    Configuration menu
    Copy the full SHA
    7beeb00 View commit details
    Browse the repository at this point in the history

  2. Don't allow PHP 7 to fail

    @rmccue
    rmccue committed Oct 6, 2015
    Configuration menu
    Copy the full SHA
    d8689ce View commit details
    Browse the repository at this point in the history

  3. Update substr check for PHP 7 

    In PHP 7, $start being the same length of the string now returns an
empty string, rather than false.
    @rmccue
    rmccue committed Oct 6, 2015
    Configuration menu
    Copy the full SHA
    2584fed View commit details
    Browse the repository at this point in the history