-
Notifications
You must be signed in to change notification settings - Fork 498
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve our tests (round 2) #170
Merged
Merged
Commits on Oct 2, 2015
-
Configuration menu - View commit details
-
Copy full SHA for b7cf797 - Browse repository at this point
Copy the full SHA b7cf797View commit details -
Use mock to test success/failure on status code
This will save **260** outgoing queries to httpbin.org
Configuration menu - View commit details
-
Copy full SHA for 80bff2c - Browse repository at this point
Copy the full SHA 80bff2cView commit details -
Use regex to match port string
DOMDocument is prone to crashing with HTML errors, and since we only care about this tiny bit, might as well use a simpler regex.
Configuration menu - View commit details
-
Copy full SHA for c50bc4c - Browse repository at this point
Copy the full SHA c50bc4cView commit details -
Configuration menu - View commit details
-
Copy full SHA for e5784a6 - Browse repository at this point
Copy the full SHA e5784a6View commit details -
Configuration menu - View commit details
-
Copy full SHA for f38dc4a - Browse repository at this point
Copy the full SHA f38dc4aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 42ac4a2 - Browse repository at this point
Copy the full SHA 42ac4a2View commit details -
Configuration menu - View commit details
-
Copy full SHA for b9d1d01 - Browse repository at this point
Copy the full SHA b9d1d01View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3e1d4f7 - Browse repository at this point
Copy the full SHA 3e1d4f7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2accbe0 - Browse repository at this point
Copy the full SHA 2accbe0View commit details -
Configuration menu - View commit details
-
Copy full SHA for cea419c - Browse repository at this point
Copy the full SHA cea419cView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.