-
Notifications
You must be signed in to change notification settings - Fork 498
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check which classes can be changed to final #514
Comments
I've done the GH searches for this. Please find my findings below. The finding table includes a proposal for select classes to become Opinions welcome.
New:
OtherAll (non-abstract) test classes will also be made |
This was referenced Sep 17, 2021
jrfnl
added a commit
that referenced
this issue
Nov 5, 2021
In PR #534 (to address #514), a number of classes were made `final`. This effectively broke the BC-layer for the Composer autoloader as that BC-layer relied on the "old" class names extending the new ones. Fixed now by: * Using the new custom autoloader - which uses class aliasing, which is not affected by the change to `final` - for the BC-layer for Composer. * Automatically loading the file via the composer `autoload` directive. While using the `files` directive in Composer `autoload` is generally a last resort, as this file only registers an autoloader and Composer autoload is used for just that purpose, this should not be a problem.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Tasks:
final
.protected
methods in thefinal
classes toprivate
.The text was updated successfully, but these errors were encountered: