Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sets stream_headers method to public to allow calling it from other places. #158

Merged
merged 1 commit into from
Jun 19, 2015

Conversation

adri
Copy link
Contributor

@adri adri commented May 9, 2015

Fixes #157.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.01%) to 87.61% when pulling dee73bc on adri:patch-1 into aa2168e on rmccue:master.

@adri
Copy link
Contributor Author

adri commented May 9, 2015

Decreased coverage seems to be related to skipped tests https://travis-ci.org/rmccue/Requests/jobs/61866354. I'm not sure why they are skipped but it shouldn't be related to the changes in this pull request.

@adri
Copy link
Contributor Author

adri commented Jun 19, 2015

Can I help to have this merged or otherwise solved?

@rmccue
Copy link
Collaborator

rmccue commented Jun 19, 2015

Hmm, is there a specific use case you need this for? It's intended to be used internally only.

@adri
Copy link
Contributor Author

adri commented Jun 19, 2015

Yeah the use case is described in this issue on php-vcr.

It would be cool to be able to record and play back requests in functional tests using the Requests library.

@rmccue
Copy link
Collaborator

rmccue commented Jun 19, 2015

Aha, gotcha, so you need to be able to call it from php-vcr directly. I don't particularly want to expose it publicly, but I'm guessing there's no real other way of doing this...

@adri
Copy link
Contributor Author

adri commented Jun 19, 2015

Well there are ways without using CURLOPT_HEADERFUNCTION but I don't think it's worth the effort.

@rmccue
Copy link
Collaborator

rmccue commented Jun 19, 2015

¯_(ツ)_/¯

I don't have a real problem with making it public, so let's merge it :)

rmccue added a commit that referenced this pull request Jun 19, 2015
Sets `stream_headers` method to public to allow calling it from other places.
@rmccue rmccue merged commit 51c64e3 into WordPress:master Jun 19, 2015
@adri adri deleted the patch-1 branch June 19, 2015 07:01
@adri
Copy link
Contributor Author

adri commented Jun 19, 2015

Thanks :-)

@jrfnl jrfnl modified the milestones: 1.7.1, 1.7 Oct 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make Requests_Transport_cURL::stream_headers accessible
4 participants