-
Notifications
You must be signed in to change notification settings - Fork 498
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make Requests_Transport_cURL::stream_headers accessible #157
Comments
(semi-related, sorry for hijacking: @rmccue, ditch 5.2 and use this neat PHP-VCR to solve the ongoing external HTTP request!!) |
@ozh At the moment php-vcr can't intercept Btw. PHP 5.3+ would only be necessary for running tests, not for the library itself. |
While fixing this issue in php-vcr I noticed that a curl header function references the protected function Requests_Transport_cURL::stream_headers.
This works as long as the caller of the callback is in the same "class scope" but not when calling it from somewhere else like php-vcr does. When running the integration tests I get the following error:
When I make the method public, it works. Would you like to do this or would you prefer another way to allow for calling this method?
The text was updated successfully, but these errors were encountered: